Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758480AbcLPTk0 (ORCPT ); Fri, 16 Dec 2016 14:40:26 -0500 Received: from mail-it0-f46.google.com ([209.85.214.46]:37105 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcLPTkS (ORCPT ); Fri, 16 Dec 2016 14:40:18 -0500 MIME-Version: 1.0 In-Reply-To: <20161216151045.8b05123396aec5598825f4c3@gmail.com> References: <20161216090033.2007806-1-arnd@arndb.de> <20161216151045.8b05123396aec5598825f4c3@gmail.com> From: Kees Cook Date: Fri, 16 Dec 2016 11:40:16 -0800 X-Google-Sender-Auth: NeyCfhai1q9eD6znbi4dHyS9GbE Message-ID: Subject: Re: [PATCH] gcc-plugin: include memmodel.h and tree_vrp.h for gcc-7 To: Emese Revfy Cc: Arnd Bergmann , Kugan , "# 3.4.x" , Michal Marek , "kernel-hardening@lists.openwall.com" , LKML , "pageexec@freemail.hu" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 51 On Fri, Dec 16, 2016 at 6:10 AM, Emese Revfy wrote: > On Fri, 16 Dec 2016 10:00:22 +0100 > Arnd Bergmann wrote: > >> Cc: stable@vger.kernel.org >> Suggested-by: Kugan >> Signed-off-by: Arnd Bergmann >> --- >> scripts/gcc-plugins/gcc-common.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h >> index 950fd2e64bb7..cb4a9518b58a 100644 >> --- a/scripts/gcc-plugins/gcc-common.h >> +++ b/scripts/gcc-plugins/gcc-common.h >> @@ -18,6 +18,9 @@ >> >> #include "tree-inline.h" >> #include "version.h" >> +#if BUILDING_GCC_VERSION >= 7000 >> +#include "memmodel.h" >> +#endif >> #include "rtl.h" >> #include "tm_p.h" >> #include "flags.h" >> @@ -66,6 +69,9 @@ >> #include "tree-flow.h" >> #else >> #include "tree-cfgcleanup.h" >> +#if BUILDING_GCC_VERSION >= 7000 >> +#include "tree-vrp.h" >> +#endif >> #include "tree-ssa-operands.h" >> #include "tree-into-ssa.h" >> #endif > > Hi, > > Could you please use the upstream gcc-common.h? You can find it here: > https://www.grsecurity.net/~paxguy1/gcc-common.h A bunch of the diff between this and the existing gcc-common.h are commented out includes. :) I'll strip out those and send the resulting patch. Thanks! -Kees -- Kees Cook Nexus Security