Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758075AbcLPUsd (ORCPT ); Fri, 16 Dec 2016 15:48:33 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754345AbcLPUsZ (ORCPT ); Fri, 16 Dec 2016 15:48:25 -0500 Subject: Re: [PATCH] fscrypt: Factor out bio specific functions To: David Gstir References: <20161216105006.10207-1-richard@nod.at> <72D4D0FB-F56D-4457-9660-4CFF7B4CFB6E@sigma-star.at> Cc: linux-fsdevel , linux-kernel@vger.kernel.org, jaegeuk@kernel.org, tytso@mit.edu, hch@infradead.org, arnd@arndb.de, dedekind1@gmail.com, linux-mtd@lists.infradead.org, adrian.hunter@intel.com, linux-ext4@vger.kernel.org, ebiggers@google.com, rdunlap@infradead.org From: Richard Weinberger Message-ID: <48d4de8e-6e57-cbad-7556-03aa788c815a@nod.at> Date: Fri, 16 Dec 2016 21:48:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <72D4D0FB-F56D-4457-9660-4CFF7B4CFB6E@sigma-star.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 16 On 16.12.2016 16:37, David Gstir wrote: >> @@ -349,33 +347,10 @@ int fscrypt_zeroout_range(const struct inode *inode, pgoff_t lblk, >> err = do_page_crypto(inode, FS_ENCRYPT, lblk, >> ZERO_PAGE(0), ciphertext_page, >> PAGE_SIZE, 0, GFP_NOFS); >> + err = fscrypt_bio_submit_page(inode, pblk, ciphertext_page); > > Any specific reason why you didn't just move the whole fscrypt_zeroout_range() to bio.c? The function depends other internal functions of crypto.c which I didn't want to export. At the end of the day it's a matter of taste. I found it less ugly to keep fscrypt_zeroout_range() in crypto.c than exposing internal stuff. Thanks, //richard