Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758726AbcLPVPe (ORCPT ); Fri, 16 Dec 2016 16:15:34 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53072 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755886AbcLPVPZ (ORCPT ); Fri, 16 Dec 2016 16:15:25 -0500 X-ME-Sender: Message-Id: <1481922923.2204853.821591377.2CD623CB@webmail.messagingengine.com> From: Hannes Frederic Sowa To: "Jason A. Donenfeld" , kernel-hardening@lists.openwall.com, "Theodore Ts'o" , George Spelvin , Andi Kleen , David Miller , David Laight , "Daniel J . Bernstein" , Eric Biggers , "Jean-Philippe Aumasson" , Linux Crypto Mailing List , LKML , Andy Lutomirski , Netdev , Tom Herbert , Linus Torvalds , Vegard Nossum MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-bb5bdba7 References: Date: Fri, 16 Dec 2016 22:15:23 +0100 In-Reply-To: Subject: Re: [kernel-hardening] Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 18 On Fri, Dec 16, 2016, at 22:01, Jason A. Donenfeld wrote: > Yes, on x86-64. But on i386 chacha20 incurs nearly the same kind of > slowdown as siphash, so I expect the comparison to be more or less > equal. There's another thing I really didn't like about your chacha20 > approach which is that it uses the /dev/urandom pool, which means > various things need to kick in in the background to refill this. > Additionally, having to refill the buffered chacha output every 32 or > so longs isn't nice. These things together make for inconsistent and > hard to understand general operating system performance, because > get_random_long is called at every process startup for ASLR. So, in > the end, I believe there's another reason for going with the siphash > approach: deterministic performance. *Hust*, so from where do you generate your key for siphash if called early from ASLR? Bye, Hannes