From: Matthew Wilcox <mawilcox@microsoft.com>
To: Heiko Stuebner <heiko@sntech.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: thermal zones break with patch "Reimplement IDR and IDA using the
 radix tree" (mainline+next)
Thread-Topic: thermal zones break with patch "Reimplement IDR and IDA using
 the radix tree" (mainline+next)
Thread-Index: AQHSV+EusKhq+NTzpU2L+9hvpr85sqELExFQ
Date: Fri, 16 Dec 2016 21:19:37 +0000
Message-ID: <BY2PR21MB00362FC819BA305D09EAF6FACB9C0@BY2PR21MB0036.namprd21.prod.outlook.com>
References: <1758112.VgMJOyEgSu@phil>
In-Reply-To: <1758112.VgMJOyEgSu@phil>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2016 21:19:37.8568
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR21MB0035
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBGLYPf3001017
Content-Length: 1277
Lines: 22

From: Heiko Stuebner [mailto:heiko@sntech.de]
> commit b05bbe3ea2db ("Reimplement IDR and IDA using the radix tree")
> seems to
> break thermal zone allocation. This happens both on todays mainline and
> linux-next-20161216 and produces errors like:

> While I haven't looked to deeply into what idr exactly does, some findings:
> - thermal_zone0 and thermal_zone1 are allocated correctly
> - every further thermal_zone always gets allocated the number "1"
> - thermal core calls idr_alloc with 0 for both start and end
> - the rewrite-patch seems to change the semantics of idr_alloc
>   where it orignally said "@end: the maximum id (exclusive, <= 0 for max)"
>   the "<= 0" part is gone now, but I checked, simply setting INT_MAX
>   as end in the thermal_core does not help

Hi Heiko,

Thanks for the report!  The problem is because the thermal subsystem calls idr_alloc() passing a NULL pointer for the data.  I have fixed this problem in my git tree but haven't sent the patch to Andrew yet.  This patch should fix the problem for you:

http://git.infradead.org/users/willy/linux-dax.git/commitdiff/c52eeed7b759c3fefe9b7f1b0a17a438df6950f3

Now ... thermal is actually using an IDR when it could save memory by using an IDA.  Are you interested in doing that conversion?