Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758924AbcLPVzH (ORCPT ); Fri, 16 Dec 2016 16:55:07 -0500 Received: from mail.ispras.ru ([83.149.199.45]:55512 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757526AbcLPVy7 (ORCPT ); Fri, 16 Dec 2016 16:54:59 -0500 From: Alexey Khoroshilov To: Shubhrajyoti Datta Cc: Alexey Khoroshilov , Rob Herring , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove() Date: Sat, 17 Dec 2016 00:54:45 +0300 Message-Id: <1481925285-594-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 405 Lines: 15 Dear Shubhrajyoti, Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") it is not clear why clk_prepare_enable(i2c->clk) is required in xiic_i2c_remove()? It is enabled in xiic_i2c_probe() and disabled/enabled in cdns_i2c_runtime_suspend()/cdns_i2c_runtime_resume(). Could you please clarify the point. -- Alexey Khoroshilov Linux Verification Center, ISPRAS web: http://linuxtesting.org