Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933546AbcLPWgu (ORCPT ); Fri, 16 Dec 2016 17:36:50 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:35069 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbcLPWgl (ORCPT ); Fri, 16 Dec 2016 17:36:41 -0500 MIME-Version: 1.0 In-Reply-To: <20161216215137.GA96800@beast> References: <20161216215137.GA96800@beast> From: "Rafael J. Wysocki" Date: Fri, 16 Dec 2016 23:36:39 +0100 X-Google-Sender-Auth: hUXG_WtZHjF096dDixLpYPuyFK0 Message-ID: Subject: Re: [PATCH] acpi: Fix format string type mistakes To: Kees Cook Cc: Robert Moore , Linux Kernel Mailing List , Lv Zheng , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Emese Revfy , "devel@acpica.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 18 On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: > From: Emese Revfy > > This adds the missing __printf attribute which allows compile time > format string checking (and will be used by the coming initify gcc > plugin). Additionally, this fixes the warnings exposed by the attribute. > > Signed-off-by: Emese Revfy > [kees: split scsi/acpi, merged attr and fix, new commit messages] > Signed-off-by: Kees Cook This modifies code that we get from an external projiect (ACPICA) and the bugs should be fixed in there in the first place. Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea. Thanks, Rafael