Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760788AbcLQBGg (ORCPT ); Fri, 16 Dec 2016 20:06:36 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:36776 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758511AbcLQBGD (ORCPT ); Fri, 16 Dec 2016 20:06:03 -0500 MIME-Version: 1.0 In-Reply-To: <20161215194703.11195-1-clabbe.montjoie@gmail.com> References: <20161215194703.11195-1-clabbe.montjoie@gmail.com> From: Julian Calaby Date: Sat, 17 Dec 2016 12:05:40 +1100 Message-ID: Subject: Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h To: Corentin Labbe Cc: "David S. Miller" , sparclinux , Arnd Bergmann , Greg KH , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 50 Hi Corentin, On Fri, Dec 16, 2016 at 6:47 AM, Corentin Labbe wrote: > This patch move the define for D7S_MINOR to include/linux/miscdevice.h. > It's better that all minor number are in the same place. > > Signed-off-by: Corentin Labbe > --- > drivers/sbus/char/display7seg.c | 1 - > include/linux/miscdevice.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c > index 33fbe82..48a5df0 100644 > --- a/drivers/sbus/char/display7seg.c > +++ b/drivers/sbus/char/display7seg.c > @@ -22,7 +22,6 @@ > > #include > > -#define D7S_MINOR 193 > #define DRIVER_NAME "d7s" > #define PFX DRIVER_NAME ": " > > diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h > index 5385d95..b1ba37aef 100644 > --- a/include/linux/miscdevice.h > +++ b/include/linux/miscdevice.h > @@ -33,6 +33,7 @@ > #define I2O_MINOR 166 > #define HWRNG_MINOR 183 > #define MICROCODE_MINOR 184 > +#define D7S_MINOR 193 I was going to say "why not change the name to something more descriptive" however they're all very abbreviated, so maybe consider a second patch series to describe what each of these is for? > #define VFIO_MINOR 196 > #define TUN_MINOR 200 > #define CUSE_MINOR 203 Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/