Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760314AbcLQQSg (ORCPT ); Sat, 17 Dec 2016 11:18:36 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41152 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758730AbcLQQSc (ORCPT ); Sat, 17 Dec 2016 11:18:32 -0500 Date: Sat, 17 Dec 2016 11:18:30 -0500 (EST) Message-Id: <20161217.111830.2082158623210373435.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: arnd@arndb.de, gregkh@linuxfoundation.org, samuel@sortiz.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 5/5] irda: irnet: add member name to the miscdevice declaration From: David Miller In-Reply-To: <20161215104250.16813-5-clabbe.montjoie@gmail.com> References: <20161215104250.16813-1-clabbe.montjoie@gmail.com> <20161215104250.16813-5-clabbe.montjoie@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Dec 2016 07:19:13 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 347 Lines: 11 From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:50 +0100 > Since the struct miscdevice have many members, it is dangerous to init > it without members name relying only on member order. > > This patch add member name to the init declaration. > > Signed-off-by: Corentin Labbe Applied.