Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759600AbcLRChY convert rfc822-to-8bit (ORCPT ); Sat, 17 Dec 2016 21:37:24 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47596 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755734AbcLRChX (ORCPT ); Sat, 17 Dec 2016 21:37:23 -0500 Date: Sat, 17 Dec 2016 21:37:21 -0500 (EST) Message-Id: <20161217.213721.2250751134919146675.davem@davemloft.net> To: grawity@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ipv6: check route protocol when deleting routes From: David Miller In-Reply-To: <20161216083059.251368-1-grawity@gmail.com> References: <20161216083059.251368-1-grawity@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-4 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Dec 2016 17:38:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 441 Lines: 12 From: Mantas Mikul?nas Date: Fri, 16 Dec 2016 10:30:59 +0200 > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can be verified using `ip -6 route del proto something`. > > Signed-off-by: Mantas Mikul?nas Applied, thanks.