Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758771AbcLRTio (ORCPT ); Sun, 18 Dec 2016 14:38:44 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36678 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbcLRTin (ORCPT ); Sun, 18 Dec 2016 14:38:43 -0500 Subject: Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c To: Greg KH References: <1482028973-10578-1-git-send-email-scott@matheina.com> <20161218074659.GA29850@kroah.com> Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Scott Matheina Message-ID: <539d33b9-c12f-a5dc-e4d3-a1b0a3e840d2@matheina.com> Date: Sun, 18 Dec 2016 13:38:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 41 I just read an email from Linus saying keep the line length shorter than 100, so my patch isn't necessary. I sent the v2 out today, but wasn't aware of 100 being the new limit checkpatch.pl still has 80 as the limit. Sorry to bother. Please disregard my patch. On 12/18/2016 11:43 AM, Scott Matheina wrote: > > > On 12/18/2016 01:46 AM, Greg KH wrote: >> On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote: >>> Signed-off-by: Scott Matheina >> I can't take patches without any changelog text :( > Yah. Forgot to add the description. Added for v2. >>> --- >>> drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++------- >>> 1 file changed, 10 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c >>> b/drivers/staging/fbtft/fb_agm1264k-fl.c >>> index a6e3af7..4e371ed 100644 >>> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c >>> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c >>> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par >>> *par, int len, ...) >>> >>> va_end(args); >>> fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, >>> - par->info->device, u8, buf, len, "%s: ", __func__); >>> - } >>> + par->info->device, u8, buf, len, >>> + "%s: ", __func__); >>> +} >> I don't think you did this correctly, do you? > I looked at this, and made a change to the line break, but if you're > talking about > the code itself then I'll have to dig into the books to figure that > out. Starting small > and learn from reading the code and making some small changes while I > figure > it out. >