Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263911AbTEOJoi (ORCPT ); Thu, 15 May 2003 05:44:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263930AbTEOJoi (ORCPT ); Thu, 15 May 2003 05:44:38 -0400 Received: from pao-ex01.pao.digeo.com ([12.47.58.20]:46565 "EHLO pao-ex01.pao.digeo.com") by vger.kernel.org with ESMTP id S263911AbTEOJoh (ORCPT ); Thu, 15 May 2003 05:44:37 -0400 Date: Thu, 15 May 2003 02:58:52 -0700 From: Andrew Morton To: Andrea Arcangeli Cc: dmccr@us.ibm.com, mika.penttila@kolumbus.fi, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Race between vmtruncate and mapped areas? Message-Id: <20030515025852.77991db3.akpm@digeo.com> In-Reply-To: <20030515094041.GA1429@dualathlon.random> References: <154080000.1052858685@baldur.austin.ibm.com> <20030513181018.4cbff906.akpm@digeo.com> <18240000.1052924530@baldur.austin.ibm.com> <20030514103421.197f177a.akpm@digeo.com> <82240000.1052934152@baldur.austin.ibm.com> <20030515004915.GR1429@dualathlon.random> <20030515013245.58bcaf8f.akpm@digeo.com> <20030515085519.GV1429@dualathlon.random> <20030515022000.0eb9db29.akpm@digeo.com> <20030515094041.GA1429@dualathlon.random> X-Mailer: Sylpheed version 0.9.0pre1 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 May 2003 09:57:22.0468 (UTC) FILETIME=[614C5640:01C31AC8] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 16 Andrea Arcangeli wrote: > > > I do think that we should push the revalidate operation over into the vm_ops. > > That'll require an extra arg to ->nopage, but it has a spare one anyway (!). > > not sure why you need a callback, the lowlevel if needed can serialize > using the same locking in the address space that vmtruncate uses. I > would wait a real case need before adding a callback. Just a vague feeling that knowing about vm_file in do_no_page() is a layering violation. I guess we can live with it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/