Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755137AbcLSJVE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Dec 2016 04:21:04 -0500
Received: from mga01.intel.com ([192.55.52.88]:51439 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755034AbcLSJVC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Dec 2016 04:21:02 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,372,1477983600"; 
   d="asc'?scan'208";a="1073901804"
From: Felipe Balbi <balbi@kernel.org>
To: Jerry Huang <jerry.huang@nxp.com>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type
In-Reply-To: <DB5PR0401MB1813EF627E02E97ECF57E65CFE910@DB5PR0401MB1813.eurprd04.prod.outlook.com>
References: <1481619983-4782-1-git-send-email-jerry.huang@nxp.com> <DB5PR0401MB1813A701FA460CA2D5C19C4FFE9C0@DB5PR0401MB1813.eurprd04.prod.outlook.com> <87k2b0fd2z.fsf@linux.intel.com> <DB5PR0401MB18132838F0F401FDCAF4BA7FFE9C0@DB5PR0401MB1813.eurprd04.prod.outlook.com> <87bmwcf69h.fsf@linux.intel.com> <DB5PR0401MB1813341E65ABDF44059E97DCFE9C0@DB5PR0401MB1813.eurprd04.prod.outlook.com> <8760mjq03b.fsf@linux.intel.com> <DB5PR0401MB1813EF627E02E97ECF57E65CFE910@DB5PR0401MB1813.eurprd04.prod.outlook.com>
Date: Mon, 19 Dec 2016 11:19:33 +0200
Message-ID: <87shpke0nu.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2475
Lines: 70

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jerry Huang <jerry.huang@nxp.com> writes:
>> >> Jerry Huang <jerry.huang@nxp.com> writes:
>> >> >> there's no need for that. This patch is in good format. I do have
>> >> >> a question,
>> >> >> however: how do you know this will work for all users? Burst size
>> >> >> is a function of how wide the interconnect where dwc3 is attached =
to,
>> is.
>> >> > So I need to generate one new property in usb node to identify my
>> >> platform?
>> >>
>> >> Well, we probably need a property to be passed, yes. But let's go
>> >> through it all first :-)
>> >
>> > I think "snps,quirk-frame-length-adjustment" is one good reference,
>> > which can pass the required value to driver from DTS file.
>>=20
>> that's not for burst increment, though.
>
> I created one new property " snps,incr-burst-type-adjustment =3D <x>,
> <y>" to identify it from usb node, and will send out the v3 patch.

okay, don't forget to Cc devicetree@vger.kernel.org. Let's see what
those guys say.

>> > So, after enable undefined length INCR burst and enable INCR16,
>> > controller will use less than or equal to 16byte.
>> >
>> >> Only Undefined INCR will be taken into consideration. Can you check
>> >> with your HW engineers what's the largest burst the interconnect is
>> >> supposed to support?
>> > I will check it with IP designer.
>>=20
>> cool, thanks :-)
>
> Have confirmed with hardware engineer, the maximum INCR burst size of
> NXP platform is 16 byte

good, thanks for that.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlhXpiUACgkQzL64meEa
mQY/bA//fFxib0qXWXAS1Jq1896J7ndmexsuSSSgYC0KH9CSLMmmYpMNpF5OuKjh
dLR78n+RZxBDbyq6f4+DR/e5Q02Gpw8YdlwEEBpRz+z0eQvxrv9PE73k1zhqSAss
hensD0mLGVYduyr/is3NU73ltQ4GMG4F77Y66MFT+3SUMQ17yegxteZaGWv/fOiK
eoENeehVPrQ6TGaRAzPboht1SVI4RcLg3n1dgH4aMqgPtM84kDp9oEOgBDjtEgzG
tRWRuAE6IBozYO+qWmzQOsyP3XHrQgm+Uz1q30tOZvTbeX7U2nEdkl24LZ0jAUgi
laSLZ/pl6cpYa/zapGwJrQH4vu94v4lsahetPmcVQsQ231wjjjIx6FvNlGEHTuhu
IdJjWEmqdwH/0DfYoUYkStWr1f+6ldvdHYQifLJUCf9MYktZm9IG6jPKSOsnF9vr
kq2tm12So2ZGUumRkFdcIPhpdX43mtQgDxAWASrMbEOyg0UlapKiQOpzNSVq0Kv/
fdKI8moVCUdGUoMgV2hQVz2IhlHmpCC/H6hwa7gPsy9voJAqTFKBhtS1bBFowRu3
ITnPWFiEZsl7t4XzsQB7ShhFVG1mgxPdOG6P3DuNGja8EjG1iFHDkUqK6pw3gwJR
2VLbHiOs1dOcKEVoHY78RacNLxGdPJ0qQ7LK+y6F/bhH1k3M/ss=
=1nZY
-----END PGP SIGNATURE-----
--=-=-=--