Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933288AbcLSKQ7 (ORCPT ); Mon, 19 Dec 2016 05:16:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:47329 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933012AbcLSKP7 (ORCPT ); Mon, 19 Dec 2016 05:15:59 -0500 Date: Mon, 19 Dec 2016 11:15:55 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Kamalesh Babulal cc: Michael Ellerman , Jessica Yu , Josh Poimboeuf , Miroslav Benes , Petr Mladek , linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Balbir Singh Subject: Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub In-Reply-To: <1481868864-27283-1-git-send-email-kamalesh@linux.vnet.ibm.com> Message-ID: References: <1481868864-27283-1-git-send-email-kamalesh@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 37 On Fri, 16 Dec 2016, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. > > Signed-off-by: Kamalesh Babulal > --- > arch/powerpc/include/asm/livepatch.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h > index a402f7f..47a03b9 100644 > --- a/arch/powerpc/include/asm/livepatch.h > +++ b/arch/powerpc/include/asm/livepatch.h > @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void) > return 0; > } > > -static inline int klp_write_module_reloc(struct module *mod, unsigned long > - type, unsigned long loc, unsigned long value) > -{ > - /* This requires infrastructure changes; we need the loadinfos. */ > - return -ENOSYS; > -} > - > static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip) > { > regs->nip = ip; Applied, thanks. -- Jiri Kosina SUSE Labs