Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755513AbcLSKZD (ORCPT ); Mon, 19 Dec 2016 05:25:03 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:35274 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161AbcLSKYF (ORCPT ); Mon, 19 Dec 2016 05:24:05 -0500 Date: Mon, 19 Dec 2016 02:24:02 -0800 From: Christoph Hellwig To: Sami Kerola Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfs: return EOPNOTSUPP when ioctl_fsthaw() is not supported Message-ID: <20161219102402.GA24893@infradead.org> References: <20161218185727.2209-1-kerolasa@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161218185727.2209-1-kerolasa@iki.fi> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 7 On Sun, Dec 18, 2016 at 06:57:27PM +0000, Sami Kerola wrote: > An attempt to freeze a filesystem that does not support such operation is > reported as EOPNOTSUPP to user. Running unfreeze to the same filesystem > returns EINVAL. Later is a little misleading, users can mix that message > with return value from unfreezing when filesystem is not frozen. This is going to break gfs2 with it's odd ->that_super method.