Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762131AbcLSLH4 (ORCPT ); Mon, 19 Dec 2016 06:07:56 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:44372 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755359AbcLSLHy (ORCPT ); Mon, 19 Dec 2016 06:07:54 -0500 Date: Mon, 19 Dec 2016 11:07:35 +0000 From: Russell King - ARM Linux To: Maninder Singh Cc: catalin.marinas@arm.com, will.deacon@arm.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, mark.rutland@arm.com, jack@suse.cz, linux-kernel@vger.kernel.org, ajeet.y@samsung.com, shijie.huang@arm.com, james.morse@arm.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, Amit Nagal , linux-arm-kernel@lists.infradead.org, pankaj.m@samsung.com Subject: Re: [PATCH 1/1] mm: call force_sig_info before prints Message-ID: <20161219110735.GR14217@n2100.armlinux.org.uk> References: <1482143832-11158-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482143832-11158-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 17 On Mon, Dec 19, 2016 at 04:07:12PM +0530, Maninder Singh wrote: > prints can delay queuing of signal, so better to print > after force_sig_info. > > Let's say process generated SIGSEGV , and some other thread sends > SIGKILL to crashing process and it gets queued before SIGSEGV becuase > of little delay due to prints so in this case coredump might not generate. In any case, that's going to be a race - you can't predict exactly when the "other thread" will send the SIGKILL in relation to the SIGSEGV. So, I don't see the point of this change. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.