Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756719AbcLSLwv (ORCPT ); Mon, 19 Dec 2016 06:52:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18707 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbcLSLws (ORCPT ); Mon, 19 Dec 2016 06:52:48 -0500 Date: Mon, 19 Dec 2016 14:52:32 +0300 From: Dan Carpenter To: Afonso Bordado Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue Message-ID: <20161219115232.GK8176@mwanda> References: <20161218164650.pgrls6ead7jfgyj4@AYYLMAO> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161218164650.pgrls6ead7jfgyj4@AYYLMAO> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 31 On Sun, Dec 18, 2016 at 04:46:50PM +0000, Afonso Bordado wrote: > Converts from CamelCase to the recommended style. > > Signed-off-by: Afonso Bordado > --- > drivers/staging/emxx_udc/emxx_udc.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 3f42fa8..cf5cdd8 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -553,25 +553,25 @@ static void _nbu2ss_dma_unmap_single( > > /*-------------------------------------------------------------------------*/ > /* Endpoint 0 OUT Transfer (PIO) */ > -static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) > +static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *p_buf, u32 length) > { > u32 i; > int nret = 0; > - u32 iWordLength = 0; > - union usb_reg_access *pBuf32 = (union usb_reg_access *)pBuf; > + u32 i_word_length = 0; > + union usb_reg_access *p_buf32 = (union usb_reg_access *)p_buf; Remove the i_ and the p_ from the new name. We don't do that in the linux kernel. regards, dan carpenter