Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759583AbcLSO5f (ORCPT ); Mon, 19 Dec 2016 09:57:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44066 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669AbcLSO5T (ORCPT ); Mon, 19 Dec 2016 09:57:19 -0500 Subject: Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Paolo Bonzini References: <20161215170648.15714-1-rkrcmar@redhat.com> <20161215170648.15714-4-rkrcmar@redhat.com> <34c85540-653c-5a83-0f3b-1ce1c8580751@redhat.com> <20161216170710.GB3637@potion> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Igor Mammedov From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 19 Dec 2016 15:57:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161216170710.GB3637@potion> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 19 Dec 2016 14:57:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 33 Am 16.12.2016 um 18:07 schrieb Radim Krčmář: > 2016-12-16 17:53+0100, Paolo Bonzini: >> On 16/12/2016 17:41, David Hildenbrand wrote: >>> >>> Just to verify: >>> >>> The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in >>> kvm_apic_broadcast() ? >> >> No, it seems wrong. > > Definitely, sending v4 of this patch. > I'll also add broadcast address check into kvm-unit-tests ... > ---8<--- > Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered > to xAPIC VCPUs and vice-versa. Make slow path behave like fast path, > which never distinguished that. > > Signed-off-by: Radim Krčmář > --- > v4: fix xAPIC broadcast address detection [David] > --- > arch/x86/kvm/lapic.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > Looks good to me. Reviewed-by: David Hildenbrand -- David