Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758533AbcLSQEY (ORCPT ); Mon, 19 Dec 2016 11:04:24 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46724 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756367AbcLSQEW (ORCPT ); Mon, 19 Dec 2016 11:04:22 -0500 Date: Mon, 19 Dec 2016 11:04:20 -0500 (EST) Message-Id: <20161219.110420.1570801461162159172.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: peter.chen@nxp.com, fw@strlen.de, david.daney@cavium.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap From: David Miller In-Reply-To: <1481742210-5609-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1481742210-5609-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Dec 2016 07:05:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 14 From: Arvind Yadav Date: Thu, 15 Dec 2016 00:33:30 +0530 > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > This error check will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav Since ioremap() is in fact designed to possibly fail, we do need to always check it's return value. So this change is correct and I have applied it to the 'net' tree. Thanks.