Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763222AbcLSQiu (ORCPT ); Mon, 19 Dec 2016 11:38:50 -0500 Received: from casper.infradead.org ([85.118.1.10]:48560 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbcLSQir (ORCPT ); Mon, 19 Dec 2016 11:38:47 -0500 Date: Mon, 19 Dec 2016 16:38:44 +0000 (GMT) From: James Simmons To: Quentin Lambert cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring In-Reply-To: <20161208203827.20561-1-lambert.quentin@gmail.com> Message-ID: References: <20161208203827.20561-1-lambert.quentin@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 31 > A recent clean-up declared och_flags as a int rather than fmode_t. This > lead to the following sparse warning: > > drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted > fmode_t degrades to integer > > This patch fixes this issue. Acked-by: James Simmons > Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h") > Signed-off-by: Quentin Lambert > --- > v2: fixes the referenced sha > > drivers/staging/lustre/lustre/include/obd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/staging/lustre/lustre/include/obd.h > +++ b/drivers/staging/lustre/lustre/include/obd.h > @@ -889,7 +889,7 @@ struct obd_client_handle { > struct md_open_data *och_mod; > struct lustre_handle och_lease_handle; /* open lock for lease */ > __u32 och_magic; > - int och_flags; > + fmode_t och_flags; > }; > > #define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed >