Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763661AbcLSQkA (ORCPT ); Mon, 19 Dec 2016 11:40:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:50129 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761136AbcLSQj5 (ORCPT ); Mon, 19 Dec 2016 11:39:57 -0500 Date: Mon, 19 Dec 2016 17:39:54 +0100 (CET) From: Miroslav Benes To: Josh Poimboeuf cc: Jessica Yu , Jiri Kosina , Petr Mladek , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michael Ellerman , Heiko Carstens , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Vojtech Pavlik , Jiri Slaby , Chris J Arges , Andy Lutomirski , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 52 On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. Yes. > Define the flags explicitly. > > Signed-off-by: Josh Poimboeuf With _TIF_SINGLESTEP and _TIF_NEED_RESCHED swapped you can add my Reviewed-by: Miroslav Benes Miroslav > --- > arch/x86/include/asm/thread_info.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h > index ad6f5eb0..1fe6043 100644 > --- a/arch/x86/include/asm/thread_info.h > +++ b/arch/x86/include/asm/thread_info.h > @@ -73,9 +73,6 @@ struct thread_info { > * thread information flags > * - these are process state flags that various assembly files > * may need to access > - * - pending work-to-be-done flags are in LSW > - * - other flags in MSW > - * Warning: layout of LSW is hardcoded in entry.S > */ > #define TIF_SYSCALL_TRACE 0 /* syscall trace active */ > #define TIF_NOTIFY_RESUME 1 /* callback before returning to user */ > @@ -133,8 +130,10 @@ struct thread_info { > > /* work to do on any return to user space */ > #define _TIF_ALLWORK_MASK \ > - ((0x0000FFFF & ~_TIF_SECCOMP) | _TIF_SYSCALL_TRACEPOINT | \ > - _TIF_NOHZ) > + (_TIF_SYSCALL_TRACE | _TIF_NOTIFY_RESUME | _TIF_SIGPENDING | \ > + _TIF_SINGLESTEP | _TIF_NEED_RESCHED | _TIF_SYSCALL_EMU | \ > + _TIF_SYSCALL_AUDIT | _TIF_USER_RETURN_NOTIFY | _TIF_UPROBE | \ > + _TIF_SYSCALL_TRACEPOINT | _TIF_NOHZ) > > /* flags to check in __switch_to() */ > #define _TIF_WORK_CTXSW \ > -- > 2.7.4 >