Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932780AbcLSRE3 (ORCPT ); Mon, 19 Dec 2016 12:04:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:50233 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763787AbcLSRE0 (ORCPT ); Mon, 19 Dec 2016 12:04:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,374,1477983600"; d="scan'208";a="914068188" Subject: Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy To: Christophe JAILLET , Xiangliang.Yu@amd.com, jdmason@kudzu.us, Allen.Hubbe@emc.com References: <20161219055255.21418-1-christophe.jaillet@wanadoo.fr> Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Dave Jiang Message-ID: <56b16dd5-b83b-e8b0-bf79-2dd2bc56f1e1@intel.com> Date: Mon, 19 Dec 2016 10:04:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219055255.21418-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 42 On 12/18/2016 10:52 PM, Christophe JAILLET wrote: > 'request_irq()' and 'free_irq()' should have the same 'dev_id'. > > Signed-off-by: Christophe JAILLET Acking the Intel driver portion. Acked-by: Dave Jiang > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 2 +- > drivers/ntb/hw/intel/ntb_hw_intel.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c > index 6ccba0d862df..a48c3e085eab 100644 > --- a/drivers/ntb/hw/amd/ntb_hw_amd.c > +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c > @@ -598,7 +598,7 @@ static int ndev_init_isr(struct amd_ntb_dev *ndev, > > err_msix_request: > while (i-- > 0) > - free_irq(ndev->msix[i].vector, ndev); > + free_irq(ndev->msix[i].vector, &ndev->vec[i]); > pci_disable_msix(pdev); > err_msix_enable: > kfree(ndev->msix); > diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c > index 7310a261c858..2413600aae30 100644 > --- a/drivers/ntb/hw/intel/ntb_hw_intel.c > +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c > @@ -472,7 +472,7 @@ static int ndev_init_isr(struct intel_ntb_dev *ndev, > > err_msix_request: > while (i-- > 0) > - free_irq(ndev->msix[i].vector, ndev); > + free_irq(ndev->msix[i].vector, &ndev->vec[i]); > pci_disable_msix(pdev); > err_msix_enable: > kfree(ndev->msix); >