Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755956AbcLSUxP (ORCPT ); Mon, 19 Dec 2016 15:53:15 -0500 Received: from forward1o.cmail.yandex.net ([37.9.109.84]:41249 "EHLO forward1o.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbcLSUxN (ORCPT ); Mon, 19 Dec 2016 15:53:13 -0500 Authentication-Results: mxback3j.mail.yandex.net; dkim=pass header.i=@yandex.com.tr From: Ozgur Karatas Envelope-From: mueddib@yandex.com.tr To: tglx@linutronix.de, dave@stgolabs.net, dvhart@linux.intel.com, bigeasy@linutronix.de, mgorman@suse.de, dingel@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com Cc: linux-kernel , Linus Torvalds , akpm@linux-foundation.org Subject: [PATCH 1/1] kernel: futex: fixed to else and initcall MIME-Version: 1.0 Message-Id: <263091482180789@web35j.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 19 Dec 2016 22:53:09 +0200 Content-Transfer-Encoding: 7bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2097 Lines: 70 The include/linux/init.h file have to content; to not used __initcall functions. I think, needs to be replaced to device_initcall. device_initcall() or more appropriate function instead of __initcall. else doesn't need to be used, if should be enclosed in parentheses. Also, I used checkpatch scripts and fixed to errors. ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ozgur Karatas --- kernel/futex.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/futex.c b/kernel/futex.c index 2c4be46..fd8a451 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -390,7 +390,7 @@ static inline int hb_waiters_pending(struct futex_hash_bucket *hb) */ static struct futex_hash_bucket *hash_futex(union futex_key *key) { - u32 hash = jhash2((u32*)&key->both.word, + u32 hash = jhash2((u32 *)&key->both.word, (sizeof(key->both.word)+sizeof(key->both.ptr))/4, key->both.offset); return &futex_queues[hash & (futex_hashsize - 1)]; @@ -545,10 +545,10 @@ get_futex_key(u32 __user *uaddr, int fshared, union futex_key *key, int rw) err = get_user_pages_fast(address, 1, 0, &page); ro = 1; } - if (err < 0) + if (err < 0) { return err; - else err = 0; + } /* * The treatment of mapping from this point on is critical. The page @@ -800,7 +800,7 @@ static int refill_pi_state_cache(void) return 0; } -static struct futex_pi_state * alloc_pi_state(void) +static struct futex_pi_state *alloc_pi_state(void) { struct futex_pi_state *pi_state = current->pi_state_cache; @@ -854,7 +854,7 @@ static void put_pi_state(struct futex_pi_state *pi_state) * Look up the task based on what TID userspace gave us. * We dont trust it. */ -static struct task_struct * futex_find_get_task(pid_t pid) +static struct task_struct *futex_find_get_task(pid_t pid) { struct task_struct *p; @@ -3323,4 +3323,4 @@ static int __init futex_init(void) return 0; } -__initcall(futex_init); +device_initcall(futex_init); -- 2.1.4