Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbcLSW4y (ORCPT ); Mon, 19 Dec 2016 17:56:54 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:41873 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbcLSW4v (ORCPT ); Mon, 19 Dec 2016 17:56:51 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: "Michael Kerrisk \(man-pages\)" Cc: "Serge E. Hallyn" , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrey Vagin , James Bottomley , "W. Trevor King" , Alexander Viro , Jonathan Corbet References: <0e229ec4-e3fc-dd46-c5b9-3afa0f14bfcd@gmail.com> Date: Tue, 20 Dec 2016 11:53:38 +1300 In-Reply-To: <0e229ec4-e3fc-dd46-c5b9-3afa0f14bfcd@gmail.com> (Michael Kerrisk's message of "Mon, 19 Dec 2016 15:38:15 +0100") Message-ID: <87bmw7pm31.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cJ6rP-00043y-LY;;;mid=<87bmw7pm31.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+lbSyC2IGJPkgixZ2Ggs8g+6G30u504Hc= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4960] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;"Michael Kerrisk \(man-pages\)" X-Spam-Relay-Country: X-Spam-Timing: total 184 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.7 (2.0%), b_tie_ro: 2.7 (1.5%), parse: 0.98 (0.5%), extract_message_metadata: 3.3 (1.8%), get_uri_detail_list: 1.31 (0.7%), tests_pri_-1000: 3.9 (2.1%), tests_pri_-950: 1.20 (0.7%), tests_pri_-900: 1.00 (0.5%), tests_pri_-400: 20 (10.8%), check_bayes: 19 (10.2%), b_tokenize: 5 (2.8%), b_tok_get_all: 7 (3.6%), b_comp_prob: 2.1 (1.1%), b_tok_touch_all: 2.7 (1.5%), b_finish: 0.74 (0.4%), tests_pri_0: 137 (74.3%), check_dkim_signature: 0.46 (0.2%), check_dkim_adsp: 3.0 (1.6%), tests_pri_500: 3.8 (2.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/2] Add further ioctl() operations for namespace discovery X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 28 "Michael Kerrisk (man-pages)" writes: > Eric, > > The code proposed in this patch series is pretty small. Is there any > chance we could make the 4.10 merge window, if the changes seem > acceptable to you? I see why you are asking but I am not comfortable with aiming for the merge window that is on-going and could close at any moment. I have seen recenly too many patches that should work fine have some odd minor issue. Like an extra _ in a label used in an ifdef that resulted in memory stomps. Linus might be more brave but i would rather wait until the next merge window, so I don't need to worry about spoiling anyone's holidays with a typo someone over looked. At first glance these patches seem reasonable. I don't see any problem with the ioctls you have added. That said I have a question. Should we provide a more direct way to find the answer to your question? Something like the access system call? I think a more direct answer would be more maintainable in the long run as it does not bind tools to specific implementation details in the future. Which could allow us to account for LSM policies and the like. Eric