Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932852AbcLSXXo (ORCPT ); Mon, 19 Dec 2016 18:23:44 -0500 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33523 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203AbcLSXXm (ORCPT ); Mon, 19 Dec 2016 18:23:42 -0500 MIME-Version: 1.0 In-Reply-To: <20161219223111.itu77g7wsqtj6cvs@rob-hp-laptop> References: <1481841044-4314-1-git-send-email-glansberry@gmail.com> <20161219223111.itu77g7wsqtj6cvs@rob-hp-laptop> From: Geoff Lansberry Date: Mon, 19 Dec 2016 18:23:00 -0500 Message-ID: Subject: Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock To: Rob Herring Cc: linux-wireless , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , mark.rutland@arm.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Greer , Justin Bronder Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBJNNrRC017561 Content-Length: 1906 Lines: 54 I can make that change, however, I worry that it may be a bit misleading, since there are only two supported clock frequencies, but a number like that to me implies that it could be set to any number you want. I'm new at this, and so I'll go ahead and change it as you request, but I'd like to hear your thoughts on my concern. Thanks Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Mon, Dec 19, 2016 at 5:31 PM, Rob Herring wrote: > On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry >> >> --- >> .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ >> drivers/nfc/trf7970a.c | 42 ++++++++++++++++------ >> 2 files changed, 34 insertions(+), 11 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> index 32b35a0..9dda879 100644 >> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt >> @@ -21,6 +21,8 @@ Optional SoC Specific Properties: >> - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum >> where an extra byte is returned by Read Multiple Block commands issued >> to Type 5 tags. >> +- crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz >> + > > Can't you use 'clock-frequency = "27000000";'? > >> >> Example (for ARM-based BeagleBone with TRF7970A on SPI1): >> >> @@ -43,6 +45,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): >> irq-status-read-quirk; >> en2-rf-quirk; >> t5t-rmb-extra-byte-quirk; >> + crystal_27mhz; >> status = "okay"; >> }; >> };