Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756843AbcLTAWe (ORCPT ); Mon, 19 Dec 2016 19:22:34 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:35191 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbcLTAWb (ORCPT ); Mon, 19 Dec 2016 19:22:31 -0500 Date: Tue, 20 Dec 2016 03:22:26 +0300 From: Cihangir Akturk To: Ozgur Karatas Cc: "corbet@lwn.net" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Documentation/unaligned-memory-access.txt: fix incorrect comparison operator Message-ID: <20161220002226.GB2970@portege.localdomain> References: <1481996537-24721-1-git-send-email-cakturk@gmail.com> <6609661482015132@web29g.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6609661482015132@web29g.yandex.ru> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 16 On Sun, Dec 18, 2016 at 12:52:12AM +0200, Ozgur Karatas wrote: > 17.12.2016, 19:43, "Cihangir Akturk" : > > In the actual implementation ether_addr_equal function tests for equality to 0 > > when returning. It seems in commit 0d74c4 it is somehow overlooked to change > > this operator to reflect the actual function. > > why this "return" function need to be ==0? I think, u16 functions read memory but "0" is should not be equalty. XOR is true only when inputs differ. That means if inputs are the same, then it outputs false (0) or whatever you call it. Then we perform OR operation between those outputs. So if the result is 0 then addr1 and addr2 is equal. > This way, -for the code to work- memory should be everytime unaligned !=0. Sorry I didn't quite get the point.