Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933197AbcLTAyL (ORCPT ); Mon, 19 Dec 2016 19:54:11 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:32917 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbcLTAyH (ORCPT ); Mon, 19 Dec 2016 19:54:07 -0500 Subject: Re: [PATCH] nvme-fabrics: remove some logically dead code performing redundant ret checks To: Colin King , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org References: <20161209145947.5766-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: James Smart Message-ID: <50aa751e-4c77-17ad-438f-5c6b9b71b02b@broadcom.com> Date: Mon, 19 Dec 2016 16:54:03 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161209145947.5766-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 43 Looks good. -- james Signed-off-by: James Smart On 12/9/2016 6:59 AM, Colin King wrote: > From: Colin Ian King > > The check to see if ret is non-zero and return this rather than count > is redundant in two occassions. It is redundant because prior to this > check, the return code ret is already checked for a non-zero error > return value and we return from the function at that point. > > Signed-off-by: Colin Ian King > --- > drivers/nvme/target/fcloop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c > index bcb8ebe..4e8e6a2 100644 > --- a/drivers/nvme/target/fcloop.c > +++ b/drivers/nvme/target/fcloop.c > @@ -845,7 +845,7 @@ fcloop_create_remote_port(struct device *dev, struct device_attribute *attr, > rport->lport = nport->lport; > nport->rport = rport; > > - return ret ? ret : count; > + return count; > } > > > @@ -952,7 +952,7 @@ fcloop_create_target_port(struct device *dev, struct device_attribute *attr, > tport->lport = nport->lport; > nport->tport = tport; > > - return ret ? ret : count; > + return count; > } > >