Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757158AbcLTGRt (ORCPT ); Tue, 20 Dec 2016 01:17:49 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:39044 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753522AbcLTGRq (ORCPT ); Tue, 20 Dec 2016 01:17:46 -0500 Date: Mon, 19 Dec 2016 22:17:44 -0800 From: Christoph Hellwig To: Scott Bauer Cc: Keith Busch , linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com, axboe@fb.com, jonathan.derrick@intel.com, viro@zeniv.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org, sagi@grimberg.me Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. Message-ID: <20161220061744.GB4765@infradead.org> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-5-git-send-email-scott.bauer@intel.com> <20161219215954.GB10634@localhost.localdomain> <20161219222311.GA2056@sbauer-Z170X-UD5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161219222311.GA2056@sbauer-Z170X-UD5> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 14 On Mon, Dec 19, 2016 at 03:23:12PM -0700, Scott Bauer wrote: > I went back and reviewed the spec 1.2.1: > > http://www.nvmexpress.org/wp-content/uploads/NVM_Express_1_2_1_Gold_20160603.pdf > Section 5.18 (page 140->141) > > Describes the security send command type and it doesn't have any reference of > a namespace ID. Anecdotally, I just removed the ns->ns_id line from the code and > everything still works as intended. Is there another portion of the spec or errata > that requires ns_id? (I can't access 1.2.1 errta the link doesn't work). As far as I can tell Security Send / Receive has always been intended to apply to the whole controller, even if that's something I would not personally think is a good idea.