Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757836AbcLTMZM (ORCPT ); Tue, 20 Dec 2016 07:25:12 -0500 Received: from mga14.intel.com ([192.55.52.115]:33022 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757544AbcLTMZK (ORCPT ); Tue, 20 Dec 2016 07:25:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="asc'?scan'208";a="20693830" From: Felipe Balbi To: John Youn , Roger Quadros , John Youn Cc: "linux-usb\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode In-Reply-To: References: <1480416997-19757-1-git-send-email-rogerq@ti.com> <1480416997-19757-2-git-send-email-rogerq@ti.com> <87k2bmo662.fsf@linux.intel.com> <4b44adf6-7569-71bf-b4c6-e811aeebfd1d@ti.com> <87h96flxj4.fsf@linux.intel.com> Date: Tue, 20 Dec 2016 14:23:38 +0200 Message-ID: <87wpeudc1h.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2710 Lines: 79 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, John Youn writes: > On 12/7/2016 7:06 PM, John Youn wrote: >> On 12/7/2016 4:44 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: >>>>>> Roger Quadros writes: >>>>>>> DCFG.DEVSPD =3D=3D 0x3 is not valid and we need to set >>>>>>> DCFG.DEVSPD to 0x1 for full speed mode. >>>>>> >>>>>> seems like it has been made invalid somewhere between 1.73a and >>>>>> 2.60a. Can you figure it out from Documentation why and when it was = made >>>>>> invalid? We might need revision checks here. >>>>>> >>>>> >>>>> I'll try to dig out more. >>>> >>>> I couldn't figure out more information on this. The changelogs in the = TRMs >>>> don't capture this change and I don't have access to all TRM versions >>>> so I can't say which version it got changed and why. >>>> >>>> Can we please involve someone from Synopsis to provide this informatio= n? >>>> Thanks. >>> >>> John, could you help us with this query? We'd like to understand why one >>> of the FULLSPEED modes got removed. Do we need a revision check or can >>> we assume that the other mode was never supposed to be used? >>> >>=20 >> Full speed is 0x1. 0x3 may still work due to how the bits are >> checked. But it definitely should be 0x1. >>=20 >> I'm not sure if it was 0x3 before. I still need to confirm whether >> that was the case or not and if so why. >>=20 > > Hi Felipe, > > According to the old databook, 0x3 was for FS in 48MHz mode for 1.1 > transceiver, which was never supported. UTMI FS was still specified as > 0x1 in those old databooks. Thank you, so Roger we should actually completely remove FULLSPEED setting of 0x3. Can you update the patch accordingly? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlhZIsoACgkQzL64meEa mQawAw//XiXmf2b/er8aE+RtvE96Dz0t/dbqH4/TlGlGDp5Z5QY8eGZJkcx0lg7f jyR445XUi7MBoOtGvtw/0MKy+zGW6Q5AR3CgXgoBmeXMi0niA9Lx8v6u2JecK/pc uAzS5dJBXlsV0Fd6Wgob3xIxHuRWJFWtbquM7+CfsE+yKbr6/EdD/WVK+MudLrqf f1MmxWRD7UiHVdnn1vkKdgvoQZmRsIAll06xEJlh8WSYSOobE1knfs5j6xrtKdSM lbte5R+mkRHMFZ4rCE6rNJPKkRPGkCwSmulN87sp/ch1w2kwhuatsmVKlrzCdaL4 I8i1XmU344zS7FRKR0FB+bPrC4UqQLAvOzLA8hDvBzysCjH2yj5tv85uUtwVPxKO WcxlvFfYdImTYbQBz1lRm3gJgpjw6+V2d9aBsE3Yw2imtJu1RBrON5q/z3jwon93 C+giWYWGhe6RzOMk0W4f0qYAlh8CXwMGEB3FvQkvqKzybj61pELD6CvO/7TSkhSL /CRVArKSCEcwapyU9n5IjcjKHT8Y6XH+utzCO3nEhL1rnn5cD/Y/GOQZHSePC96b M1BTrYNbOn7N288k8L+WIW3qFGT9icfY1QeebwtJYfSae1Aa/LGk8U0MGpmxFT3Z SNrSccbT+ehzbbVHBP8sKrlL1UjSDEfj41393MGVmYJFizH/WH0= =us+i -----END PGP SIGNATURE----- --=-=-=--