Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755394AbcLTNEk (ORCPT ); Tue, 20 Dec 2016 08:04:40 -0500 Received: from foss.arm.com ([217.140.101.70]:41434 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbcLTNEi (ORCPT ); Tue, 20 Dec 2016 08:04:38 -0500 Subject: Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics To: Samuel Thibault , Paul Turner , LKML , Peter Zijlstra , Thomas Gleixner , Ingo Molnar References: <20161219224014.GA28238@var.home> <20161219230713.GD2895@var.home> <20161219232926.GH2895@var.home> <20161219234525.GI2895@var.home> From: Dietmar Eggemann Message-ID: Date: Tue, 20 Dec 2016 14:04:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219234525.GI2895@var.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 24 Hi Samuel, On 12/20/2016 12:45 AM, Samuel Thibault wrote: > Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote: >> On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault >> wrote: >>> Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote: [...] >> The MIN_SHARES you are seeing here is overloaded. >> In the unscaled case this needs to be MIN_SHARES, and in the scaled >> case, the subdivision of the scaled values must still be >=2. > > Ok, now I understand. I have to say this overloading is confusing. > > Samuel this had been already discussed back in August when I posted the original patch. https://lkml.org/lkml/2016/8/22/351 https://lkml.org/lkml/2016/8/23/641