Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757580AbcLTNQG (ORCPT ); Tue, 20 Dec 2016 08:16:06 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:58522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbcLTNQD (ORCPT ); Tue, 20 Dec 2016 08:16:03 -0500 Date: Tue, 20 Dec 2016 14:15:57 +0100 From: Peter Zijlstra To: Dietmar Eggemann Cc: Samuel Thibault , Paul Turner , LKML , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Message-ID: <20161220131557.GN3124@twins.programming.kicks-ass.net> References: <20161219224014.GA28238@var.home> <20161219230713.GD2895@var.home> <20161219232926.GH2895@var.home> <20161219234525.GI2895@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 23 On Tue, Dec 20, 2016 at 02:04:34PM +0100, Dietmar Eggemann wrote: > Hi Samuel, > > On 12/20/2016 12:45 AM, Samuel Thibault wrote: > >Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote: > >>On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault > >> wrote: > >>>Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote: > > [...] > > >>The MIN_SHARES you are seeing here is overloaded. > >>In the unscaled case this needs to be MIN_SHARES, and in the scaled > >>case, the subdivision of the scaled values must still be >=2. > > > >Ok, now I understand. I have to say this overloading is confusing. > > > >Samuel > > this had been already discussed back in August when I posted the original > patch. Maybe we should put a comment in to avoid getting more of these ;-)