Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759360AbcLTNWO (ORCPT ); Tue, 20 Dec 2016 08:22:14 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:37523 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbcLTNWM (ORCPT ); Tue, 20 Dec 2016 08:22:12 -0500 Date: Tue, 20 Dec 2016 14:22:03 +0100 From: Samuel Thibault To: Dietmar Eggemann Cc: Paul Turner , LKML , Peter Zijlstra , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Message-ID: <20161220132203.GD2895@var.home> Mail-Followup-To: Samuel Thibault , Dietmar Eggemann , Paul Turner , LKML , Peter Zijlstra , Thomas Gleixner , Ingo Molnar References: <20161219224014.GA28238@var.home> <20161219230713.GD2895@var.home> <20161219232926.GH2895@var.home> <20161219234525.GI2895@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 24 Dietmar Eggemann, on Tue 20 Dec 2016 14:04:34 +0100, wrote: > On 12/20/2016 12:45 AM, Samuel Thibault wrote: > >Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote: > >>On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault > >> wrote: > >>>Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote: > > [...] > > >>The MIN_SHARES you are seeing here is overloaded. > >>In the unscaled case this needs to be MIN_SHARES, and in the scaled > >>case, the subdivision of the scaled values must still be >=2. > > > >Ok, now I understand. I have to say this overloading is confusing. > > > >Samuel > > this had been already discussed back in August when I posted the original > patch. But that doesn't show up in the source code or git history. One shouldn't have to dig mailing lists to get code comments :) Samuel