Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933901AbcLTPqq (ORCPT ); Tue, 20 Dec 2016 10:46:46 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:47086 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764589AbcLTPqm (ORCPT ); Tue, 20 Dec 2016 10:46:42 -0500 Date: Tue, 20 Dec 2016 07:46:39 -0800 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Scott Bauer , linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com, axboe@fb.com, jonathan.derrick@intel.com, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, sagi@grimberg.me Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. Message-ID: <20161220154639.GA16393@infradead.org> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-5-git-send-email-scott.bauer@intel.com> <20161219215954.GB10634@localhost.localdomain> <20161219222311.GA2056@sbauer-Z170X-UD5> <20161220061744.GB4765@infradead.org> <20161220154916.GC10634@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161220154916.GC10634@localhost.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 12 On Tue, Dec 20, 2016 at 10:49:16AM -0500, Keith Busch wrote: > On Mon, Dec 19, 2016 at 10:17:44PM -0800, Christoph Hellwig wrote: > > As far as I can tell Security Send / Receive has always been intended to > > apply to the whole controller, even if that's something I would not > > personally think is a good idea. > > NVMe security commands required the namespace ID since the very > beginning. It's currently documented in figure 42 of section 5, > "Namespace Identifier Used" column. Oh, for some reason I read a no there when looking it up. Good to know, although TCG spec still seem to ignore it.