From: "Liang, Kan" <kan.liang@intel.com>
To: Jiri Olsa <jolsa@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        "Ingo Molnar" <mingo@kernel.org>
CC: "Jiri Olsa (jolsa@kernel.org)" <jolsa@kernel.org>,
        Andi Kleen <andi@firstfloor.org>, lkml <linux-kernel@vger.kernel.org>,
        Michael Petlan <mpetlan@redhat.com>
Subject: RE: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question
Thread-Topic: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question
Thread-Index: AQHSSzJ8QmQH3wRWmkOE9GJRGPB73aDzSKXg//99YoCAEa7+YIACak2AgApgd2A=
Date: Tue, 20 Dec 2016 18:05:16 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F07753683434@SHSMSX103.ccr.corp.intel.com>
References: <20161130105105.GA25720@krava>
 <37D7C6CF3E00A74B8858931C1DB2F07750CA4697@SHSMSX103.ccr.corp.intel.com>
 <878ts0vos0.fsf@firstfloor.org>
 <37D7C6CF3E00A74B8858931C1DB2F07750CA4D86@SHSMSX103.ccr.corp.intel.com>
 <20161201163755.GM3092@twins.programming.kicks-ass.net>
 <37D7C6CF3E00A74B8858931C1DB2F077536777DA@SHSMSX103.ccr.corp.intel.com>
 <20161214113339.GA2960@krava>
In-Reply-To: <20161214113339.GA2960@krava>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1766
Lines: 55


> On Mon, Dec 12, 2016 at 02:49:03PM +0000, Liang, Kan wrote:
> >
> >
> > > I really would prefer to move the thing to its own PMU.
> >
> > The patch as below creates a new PMU to fix the issue.
> >
> > Jirka, could you please try the patch on your machine?
> >
> >
> > Thanks,
> > Kan
> > -------
> > From 2de8b2eda6b54734e08a608b5fc8c367b94369d3 Mon Sep 17
> 00:00:00 2001
> > From: Kan Liang <kan.liang@intel.com>
> > Date: Mon, 12 Dec 2016 09:03:35 -0500
> > Subject: [PATCH] perf/x86/intel/uncore: fix nonexistent clockticks
> > event for  client uncore
> >
> > The clockticks event can only be used by the first Cbox pmu. Other
> > Cboxes don't allow to open clockticks event, eventhough it's announced
> > via /sys/../events/..
> >
> > For client uncore, there is only one clocktick fixed counter. Current
> > kernel code forces that only the first box can access the fixed
> > counter in uncore_pmu_event_init. But it doesn't take care of the the
> > attr_groups. All the pmus of same type share the same attr_groups. If
> > the clockticks event is set for the first box, user can also observe
> > the event in other boxes.
> >
> > The clocktick fixed counter is a standalone counter. It should be
> > removed from the Cbox PMUs. A new type of PMU is added which only
> > supports fixed counter events.
> >
> > User observable changes with the patch.
> > clockticks event is removed from Cbox. It will return unsupported, if
> > uncore_cbox_0/clockticks/ is accessed. User may need to change their
> > script to use uncore_clock/clockticks/ to instead.
> >
> > Signed-off-by: Kan Liang <kan.liang@intel.com>
> 
> seems ok
> 
> Tested-by: Jiri Olsa <jolsa@redhat.com>
> 

Hi Peter and Ingo,

Any comments for the patch?
Do I need to re-send it?

Thanks,
Kan