Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764962AbcLTS3O (ORCPT ); Tue, 20 Dec 2016 13:29:14 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:47474 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758226AbcLTS3L (ORCPT ); Tue, 20 Dec 2016 13:29:11 -0500 Date: Tue, 20 Dec 2016 13:28:43 -0500 From: Josef Bacik Subject: Re: kernel/bpf/verifier.c: 4 * possible unintended fallthrough ? To: David Binderman CC: Alexei Starovoitov , "ast@kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <1482258523.24490.10@smtp.office365.com> In-Reply-To: References: X-Mailer: geary/0.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [2620:10d:c091:180::379c] X-ClientProxiedBy: BN6PR09CA0009.namprd09.prod.outlook.com (10.172.16.19) To BN6PR15MB1315.namprd15.prod.outlook.com (10.172.206.141) X-MS-Office365-Filtering-Correlation-Id: 52f636ac-de5b-4fe0-b4a8-08d429060b80 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1315; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;3:XCwCiGxpAmqAtoMfPOeEWWvQOEhu9bummyrNQ6pGCDgX+Nlnth1woifVEHWvqSfwbTzfEZN9qVKhcLbMdXbJ3aKuEgM3I8yPEnlWCYY83lfdBWWBgfH7whig29ac6OvtSgfsp3qfLULjVjnCOx5BnzY5UbFMsshU32Wi6dbeSH7ffX07oQZUaK+uQxDLQU/NNUPFlSyj2THFqSOaSDiR7a5qZLrD+NO8aiN5s+nookbJtGkf2dZAhLKyWHXwdCeGhEvG8VEd4aVJBcZtuSUXVw== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;25:usEymhlZx8Zxp+LrSxNACpXUmzEJwSGBm8QTV8vW8HZz0Xe8Huo8D9QJqF925gLeBOqDZu2sR1d33DNgwS082yZC2tm2NnCmrgIw2xXeKrXpNzvNnat5962aDqRjGg6yg66eIJPcP4uZMFdTAycCHb3+IcUyozOi5Vghgp3y084lbMfSE/FWlWGADHL3S+0or/ao+4dWwQVAx3GrZFRRTPD5yCVkarCt7OTkRgt87O2K1vXzqHLSnNbkhvPlw/zOmpP0F1ZAl6E2WkD+4+unWwl0G66GplK82Jp6VofBE7ziDwb1shFMUsyG/ttA7pvfMpDzsixUABa+retfTHygmu1FHkOBsh6XTvLcK+c4ymy+FQK+drjEK0cdi4RNfNxZTWq2UiZGC3yWjsSlsTVKs6hlhs3HKxMKzDg/SpCr7zXjod8PHW48qrwalTMdiT/LLcz+QPiBRIYT3tRSQFNClFTzAJwLCnxYK7F0kyUthDFdK0C+0eRwdSUkjlHiYA6+NaSjRQ1YnELmqbO3RfkCpGV3PKj6f0Ul6if0oUrPEQHe2Ygkv7i/3P1DssKuv+1h8Zhc250qL9y8zmeqLxSRZkQjzuyvtSTnkbtISdb1afTaNf3M4oZf7VA8S7nTYoNbKZyIfxbBHCDfq6u/l8VpsoCnocjJPGr4SVUk0aI2O2D7iOLleRXohp+Vcw0sw3SibFteLnmEwg9iNRErzdlCCgyAIPHudOywPiuiE3M0S6t4JPicv5kdcuFTJlpEvZIt+D5oW2ycB2Lmtyc9yc4CmmJli1hZ5ybr6egBLdKvxj0dIsqbkEOaOL2f6J/yHZE7dnKvkV+QhW/vrPBYiOh5KA== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;31:R97eXm9i1NQyyVSi7otqQr0hTnWT4pPOLAcLVbN9xtTsSf7RYiUmqEg38/vVVedRUM17BVEB6kvIK6lc2kvFIzzrxr1jvLm3/0/UVUL2epamOJBREHqck5f/2K+yROgJthwkgSHruulPRXdi3nbc/JU7w8uQbgKrOB0I56NGmWC56IxP4rs2wQfEN/DW5nBIBvtMT/gsXQot1QZCU+C0LCmcvHba1AEWD/hNktDD528/6BdB4QzgIDhe4y4no3oT8Di24kG0SHvqZZsLya8dDA==;20:yyRIkIxzX/MVDoL/QL49btP6HIZ6UHS4SKggu0x/rAntZceXMlwbuuCBj0oFL1I0TAJ+clc85OihvFVLziDQAVYRyM6Qt5rU1UIdFuX2BzCYjGKKtEOnsX8mgn8GSkFiBKpmih33f3h8Z8BwtMbILE9cyKwQocmlqMY2PTY3eXR1IrSvvzYP9gAViTfBYiKJaL0hpIcJdcbBKuPHyqypPcXuda/5zpAU77j+9Yy15+oz2GlpbH8mHwBbvQhhD/TbQPK478hLh6c2XeuJst4KJTz23OGx3PTktTnYR7/+jFl6Z0Ls8HwuqgB63GMAzCMdT/ifjvmVRo8twqf/FsR6ry0U6EJNDxZUnsgKq80JuXuu2DM5dZIFrOKYSZ8nT8dV4qG5o68EJm2ToRHIUxtTfVb3ofWJSSEgwQL/Ei6unwS4Dmms+Zh5EtGLmay3qVh8glaOHxGxcBassG1P7k6URSLImGwbYwsQVMrKoPGRE9674yb580rI5lodJtdZyHX/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(194151415913766); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:BN6PR15MB1315;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1315; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;4:K42myQTlrTjwV8qcscxy171l4SJguGtYF098QTSblxcyTfgBgaBBcdolb9H1mQp5K5Y7ZsfoglycrKoKKk05H/FPFcKegHNHocfWXOWS+UQizCs5cLoZ1QG2qEFdrPrEIR2iYKTHxZu4hogSUXQegNEsExE0rVFmu9AHpkV9lL/pCkg3XjfrtT9t07cfmioUuk0R98s7TSBFE3nZgQtG7cW1fi0/rAl9ELaOmv6Lb8Wb64zz3VBwPmvscszIueIdbX/BzWIL5YbXmz//EQzALxz+ZxFxxTHwqxQ/Zgx7iHJqCkNwAiwZXQgliszgycojaMvjl6xd0XnIEzZlbuEjZqWxq2MuyQf8Wbm4pKcuGuVXJI0hMUAVR+kPhJ2B/fzAPGHNHW9ZvNA8AVBRTZ2OjeVaWQhxFSHWSM/Tf/CnN2f+lsCwYPbNhtvPvE8519jRn3qpBonAV3tYKZjc31SuTd4e9EdP6Ztq+CzOdwtZue9NICAjgEqbT7/wVnBMHsTIZCuMY0KbhdaYclet3LbdIo7d5hy8zlec4CmmbaHZF/mUju4DmDawVpC/AJCsTcQZFSkuufBDQ1z2dtQCnnwTIdL682eszM65uNPAYQhSo8iLeAiQzt9aN8eYlHhBK1On X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(199003)(189002)(24454002)(377454003)(6666003)(229853002)(5660300001)(38730400001)(92566002)(50466002)(81166006)(81156014)(189998001)(76176999)(106356001)(88526003)(6116002)(101416001)(6506006)(50226002)(105586002)(2906002)(2950100002)(42186005)(8676002)(4326007)(9686002)(68736007)(6512006)(97736004)(6486002)(110136003)(47776003)(25786008)(7736002)(39060400001)(305945005)(50986999)(86362001)(23676002)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1315;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMzE1OzIzOmpEZEhENGhKNG1aOHVlN2V3RHZQUCtxbG5v?= =?utf-8?B?V0lDTjFMZ0hhUEpWNFNzQlFRbGl4dTYvQkRCN1hyU0JmeDYwLzlxVnBGQUpG?= =?utf-8?B?ZnE3dXdESE9NaG5rOGxlWnFZOWJBOHhuTDhYZTdJSVFLUVd0dTNZdStER2VU?= =?utf-8?B?QzFKaFU4Z3NaNUpXZ05mNTdKQXk0d2laYTlacE81Z1B1VTdmWERBRDV2KzZG?= =?utf-8?B?MC8xeUZIRXZTS3VFZ0tsZ0xwcjR1aVZGbXNjeGdObmc5WmNPcjlhZmZNWEFi?= =?utf-8?B?VUFuOTllNWdWS2UrQTNaUGhJTjM1bHRNTEpCZ3V2L2FUYllkNU5nZlJxR2Fz?= =?utf-8?B?bVpBRjloV0RMZndBOUlPSWxydTdKUzFSSGJyNVBncHpuSVJBSnZTam15bGxL?= =?utf-8?B?WmtXeVFacXhEb2NhdUJQcUZycnZKLzQyUjNRQzNBMVI3Y29DWVYxODhvRklt?= =?utf-8?B?WkZTZG9EQ3lRMUxBY2NreEZqZnRnWjBTaHR1M09XMHpNWHBpT3ltODFrVzJH?= =?utf-8?B?eXp6Uk9MNWZZQWZSS2EwL3NrSHgzWklCZFNxS3pzU29tbmZNaUszVlFNY1VU?= =?utf-8?B?cGhZaGY3dnN6SG9Fa2lvMkRYU1RPMzVzenFlN2k1bUF5ZFFaWUJVU0tJeUk1?= =?utf-8?B?My9RVnFrTURMU2ZETmVVTkZPZlZEWnRCcHkxa1hyQ1NvZVVVVVpGM1hnUTI2?= =?utf-8?B?UkxQaSttaXBqRkJTOEgvRjF4ZE55cGcrTEZwNUJrVWhhWTNOa3JnMmNzK0sv?= =?utf-8?B?TjNXTm9jTTV6OSt0KzBKUkxBb3ZhelFqRTJpZWg1a0lyLzVPUm1PSmZuR2Y4?= =?utf-8?B?QzhmaWpaYkJaUUVoNmRyY1FOaFgzMkdsTEFXdElwdXhlK2hOL1VJWU9uNzJS?= =?utf-8?B?ZWRGL1RqTWpsS29hVTJuaXI3NDRqWktmRDZoYTFad2lUTWYxN2d2clI5TUI2?= =?utf-8?B?Q1BicUVqTDhJUzlIYUxBVWxnU01IUW95NTc5WC8zRUdaZUYzQTBXbmxPR3hk?= =?utf-8?B?bVFwL0FIS1pYMXVBQlpDTGtzRmIwS1h3Y3MwVFZLN3lWTUlaV0JjTWJiZE43?= =?utf-8?B?ZWI1YXBreEphZUlaSGpMbnY1QXhYKzIwekt5VllveGNRQXJnb1BzWFo3VG5x?= =?utf-8?B?U2puaENFWGhRSTFMWmVxazVxcU9RdDFxaUUwU0tieXl0K2haWmQzUUtBWU5P?= =?utf-8?B?RGZIam9qanZGM1RJTVorS0RVY2lxWjNaSVdoSzZqcnh0eHJTcjFzUk01K3pH?= =?utf-8?B?UlNUNlVUWEZITmU2S3JJWDh0N0tKTmxwS3FSS0tRYVRGRGVjMmExUkd3dHRC?= =?utf-8?B?SlBpSVdNNEhONHVDc2tmNWFRNzArU3FKNUljV0QzVDc4ZXR3ZXRNdjlZTzdV?= =?utf-8?B?M0sxcXU4V2ZNanFVQ1VuaUkxSlJ0bDRPY2JoS21laG5zSFhVckgvUHN0MWxR?= =?utf-8?B?QWROQkdMVTc5dUYyeFFUZTVNUGRuRFVHS0FpUVl4MTU1RUlNQzY4MllHaC9V?= =?utf-8?Q?Spxop9p0K2X7YVeeoAzHWfuH0=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;6:uVisMiTF6fMoM28DnFqY6Mpgx96KI17ZFWZkDffemm1ZBxD0pYGFpvJ9dkb39iC8wV8Qm1RIi/v2nLKAPeMuImFsx8ciGjYfOaDyyF8Z923JmWRd9dQdD5cFxF4cjq+QypaxXvSJXNVdWY6dUQkajxUoKg+fJDna7+ayLtA0np9V1VIPHBD5g09ixMS6ccmTSTXihLgiwXqn658m0r/lH1nNR04pjvKfXouFq2NL4NIdhC5n1csv5aifgHjn207Tx47QTa8bfc5FQnJ5aRsJQNa7WPey7bVxxA4lTMCdfKbnFuJlQ8+h/uqRJ58kFfgKjWv0R6eJX/j6E30rOBNLJgJe+0h5tjeI9g6+HORSyDGuKXm+JbM4HoQDVE824c80J0L+nqP8gIUrvkhbDfANCnY8eicGXL0lcQAlnSDtXT8=;5:xNL75qj7suMslMABtcDvxH9lZo/IbukVdpfl5jhWQd4xUxj3cOasiscN9uXcoMbLU+VHVh+9ty5JjE6BFVFKYG2XWuWy5x5gYGyga9Bn5AAnEXE6sHs6MYVOTPR9fv8RStOisJtkF5jEiumR2NJ1H+QDGQOFKqEZpwtpXM+Nlt4=;24:mLVpjTdY+zilfbjLpn8zA2IjCi4jbhZBitWT2jJiWJI8WrpM9FXGuC59lgi7408OrS40KPejiToBQI08mDglq4Yjj5hWTXCX65V8w+myhwk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;7:MJDQM2Va/cLydi/d1c/lnCWkntmYTnXcNGj+5kZnunUn0umLzfwQCLCIuE97bztWVAhTU0JDtOi7J5H7x5/17T6D2WPWCnytZTAn1tCnwjTnsM94zXRpPPIZHHxpXYObty1ZSQ9CLTZyuk8XiC+1/RorYAs5VYDZFH5PvXjB1kYwj0LWwRvDny9yDW88RUkCTknObGk0OP8Z5qJUidw6ZSzZtUHnTIMVD/HzbjA49XRuYBQzkgCgqefyctEBARxXAbYI5nx3j8XyigJOMJuVPtjP0yW+LWOkaH0Mluto+st6fd1sIu5EOywowlHH3CzU6UGjUBkzIzzGZmw8nLbflzEaBUo0RwrkKdgSOapKrC+A7WyVIotGRN+Grp0cDJUy/L34d731oA3IK4PXJdZPcQ/+tFoiP27aabJz8WSgC+INKI0bRgu6X6Ohnsa1HR8rEPW8nLgniCYtQN5arTPp5A==;20:yTVza02+oYWdvtJqtZ0sm2k4YNo6+POozkBaTHmn0MSyn++u22n0EgRcbxdD92hTn20YbxEYpMZQx/6+DRfj/bWt2tGerasYEnCczHIv2MFMbg6qr6AQKoz+nNNpeiGt2t6j83dH1VUhlzNkENR488UGjE9OtSwui4/yTEyA4Wk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 18:28:49.4469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1315 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-20_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 25 On Tue, Dec 20, 2016 at 11:34 AM, David Binderman wrote: > > Hello there, > >> From: Alexei Starovoitov >> I've tried 4.9 and 5.2 and don't see this warning. > > As expected - I used a development version of gcc. > Latest released version is 6.2 > >> Is this 6.x gcc? > > 7.0 would be more accurate. > >> I suspect it will have such warnings all over the kernel. > > Indeed it has hundreds, but the subject under discussion is file > kernel/bpf/verifier.c. > > I am still not sure if I have found a fallthrough bug or not. You haven't, this is intended so is a useless warning. Thanks, Josef