Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936343AbcLTTF4 (ORCPT ); Tue, 20 Dec 2016 14:05:56 -0500 Received: from mout.gmx.net ([212.227.15.19]:56483 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936000AbcLTTFw (ORCPT ); Tue, 20 Dec 2016 14:05:52 -0500 From: Heinrich Schuchardt To: Pantelis Antoniou , Rob Herring , Mark Rutland , Frank Rowand Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 4/4 v2] of/overlay: test count and destroy_last Date: Tue, 20 Dec 2016 20:04:55 +0100 Message-Id: <20161220190455.25115-5-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161220190455.25115-1-xypron.glpk@gmx.de> References: <20161220190455.25115-1-xypron.glpk@gmx.de> X-Provags-ID: V03:K0:nBMpof2SpiGV7PKr6MmCcZkhbAfgsujNAanRO1hyiBTakUU4WZf Nl0ItXD7stnJnXoDxug5M4EnjN98ItJoC7wWX+vWuQVNm52A4EV5WvKdE3kejRUALQ38Zue wt/JHHXh+Y1URHGkg4ix/sKkWVvnXO7trh1cDjk2q8AZQZqWkWnDP+KFRaWNvR9Kkx+ZUeN ZUg6StEFCxHEhz2EafFHw== X-UI-Out-Filterresults: notjunk:1;V01:K0:DQKnai6eaJk=:5V2eA6b/OhmZcGB8LqNFp4 VLIT3U3fafHF1s/KQyJcB8wt0jTpBhraQRbEE86HhTnHsDwqi2yuNKJUS7v0Nqg8RZg5GZDV7 GXZg5JPtCesPbBDjSIhDuxbPqZcTf1sm9gZzUUb6PQhQdLVJP54aQjmULA9HBa8amzyOWmgA0 olUbsvNkH5TB7Ug9Hh0of7Ob8O5JC0V9hBxpbac6MAyeZsVFPYRcoDOhAHWnQoIXd5H9+jKuO BsvVbKbycR/L3JC7kGSy0b4Wl+9DexCv12NMVzqwt3GHvde0Z5Ldn82M61uqR+1+zOhrxB5Cz FVUwvFIMTZOLXzguhauT9QDUh5iT5tabG/0I/BepUHzHc0V/tFLOY3BzaIx86giB5iwpLYubK JaLgGi3jR8X/higJV8Yb/uRU5AVtaX0CTV84KXYy7/2tqiOGUz1HIOk2V1pbJBkbmF/lCjzUD sfdcnRnAh007U0hk8DsFNYKO7/HK2u48pdtl/rleMNBIrU5m1AfTGWyKYGqSTGnbJgnKRUynE O6HasoddqfcpFT33JkJ+c0Y65WSLCf/sX2zEETg+gYCfsRH+zzljS1x3oStbR+uZvQ/Zzi9MX LtmV7j8kKL4yx82ps6q8XA2ErTld8qRyukjhY3iOdVPjqZtuejruk9lXdpet7RoImeNAoxzcb UJVUXseCiFwTxDKqgslg4i5KxCgp0XkYyJRThX4F8HkK8GnTv9fAf5nBAE2/EuCGYUQP4CRpp ObDEa7s1Y1FscFK9WJES0mPzfAau45iGr8c5xMmsdcMk7otJaPVKo+9NCqk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 62 In the unit tests check that the functions of_overlay_destroy_last() and of_overlay_count() work as expected. Signed-off-by: Heinrich Schuchardt --- v2: Added this patch drivers/of/unittest.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 53c83d6..e3fbf0b 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1466,6 +1466,7 @@ static void of_unittest_overlay_8(void) struct device_node *np; int ret, i, ov_id[2]; int overlay_nr = 8, unittest_nr = 8; + int count_before = of_overlay_count(); /* we don't care about device state in this test */ @@ -1485,6 +1486,12 @@ static void of_unittest_overlay_8(void) overlay_path(overlay_nr + i)); return; } + + if (count_before + i + 1 != of_overlay_count()) { + unittest(0, "count does not increment by 1\n"); + return; + } + ov_id[i] = ret; of_unittest_track_overlay(ov_id[i]); } @@ -1501,7 +1508,7 @@ static void of_unittest_overlay_8(void) /* removing them in order should work */ for (i = 1; i >= 0; i--) { - ret = of_overlay_destroy(ov_id[i]); + ret = of_overlay_destroy_last(); if (ret != 0) { unittest(0, "overlay @\"%s\" not destroyed @\"%s\"\n", overlay_path(overlay_nr + i), @@ -1509,6 +1516,12 @@ static void of_unittest_overlay_8(void) PDEV_OVERLAY)); return; } + + if (count_before + i != of_overlay_count()) { + unittest(0, "count does not decrement by 1\n"); + return; + } + of_unittest_untrack_overlay(ov_id[i]); } -- 2.10.2