Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934271AbcLTWHl convert rfc822-to-8bit (ORCPT ); Tue, 20 Dec 2016 17:07:41 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:25104 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754571AbcLTWHj (ORCPT ); Tue, 20 Dec 2016 17:07:39 -0500 Date: Tue, 20 Dec 2016 17:07:20 -0500 From: Konrad Rzeszutek Wilk To: Eric Dumazet Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Geliang Tang , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/blkback: use rb_entry() Message-ID: <20161220220720.GS19380@char.us.oracle.com> References: <20161220164703.GL10069@char.us.oracle.com> <20161220174406.uewt5mhniwtznran@dhcp-3-221.uk.xensource.com> <20161220175113.GB16671@char.us.oracle.com> <1482270801.1521.25.camel@edumazet-glaptop3.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1482270801.1521.25.camel@edumazet-glaptop3.roam.corp.google.com> User-Agent: Mutt/1.7.1 (2016-10-04) Content-Transfer-Encoding: 8BIT X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 40 On Tue, Dec 20, 2016 at 01:53:21PM -0800, Eric Dumazet wrote: > On Tue, 2016-12-20 at 12:51 -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 20, 2016 at 05:44:06PM +0000, Roger Pau Monn? wrote: > > > On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > > > > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > > > > To make the code clearer, use rb_entry() instead of container_of() to > > > > > deal with rbtree. > > > > > > > > That is OK but I think 'container_of' is more clear. > > > > > > > > Roger, thoughts? > > > > > > I think so, container_of is a global macro that's widely used and everyone > > > knows, rb_entry OTOH it's not and it's use doesn't really simply the code at > > > all. I'm not really opposed, but it seems kind of a pointless change (not that > > > it's wrong). > > > > I concur. > > > > Geliang Tang, > > > > Thank you for the patch but there is no need for it. > > The same could be said of list_entry() > Sure. And I am used to that as well :-) > #define hlist_entry(ptr, type, member) container_of(ptr,type,member) > > #define list_entry(ptr, type, member) container_of(ptr, type, member) > > # git grep -n list_entry | wc -l > 3636 > > rb_entry() will probably make its way everywhere. That is good to know. But for right now this patch is not necessary. Thank you!