Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938026AbcLUCHW (ORCPT ); Tue, 20 Dec 2016 21:07:22 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48890 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932778AbcLUCHT (ORCPT ); Tue, 20 Dec 2016 21:07:19 -0500 X-ME-Sender: X-Sasl-enc: 5puF1Ow46xXGIiLIlMaCX1UWNSLta67S7UaB+i++36EQ 1482286038 Date: Tue, 20 Dec 2016 19:07:17 -0700 From: Mark Greer To: Geoff Lansberry Cc: Rob Herring , linux-wireless , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , mark.rutland@arm.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Justin Bronder Subject: Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Message-ID: <20161221020717.GA5444@animalcreek.com> References: <1481841044-4314-1-git-send-email-glansberry@gmail.com> <1481841044-4314-2-git-send-email-glansberry@gmail.com> <20161219223504.ttwayzpfvdumgouu@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Animal Creek Technologies, Inc. User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 45 On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote: > On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > >> From: Geoff Lansberry > >> > >> --- > >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > >> drivers/nfc/trf7970a.c | 13 ++++++++++++- > >> 2 files changed, 14 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> index 9dda879..208f045 100644 > >> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt > >> @@ -21,6 +21,7 @@ Optional SoC Specific Properties: > >> - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum > >> where an extra byte is returned by Read Multiple Block commands issued > >> to Type 5 tags. > >> +- vdd_io_1v8: Set to specify that the trf7970a io voltage should be set to 1.8V > > > > Use the regulator binding and provide a fixed 1.8V supply. > > > >> - crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz > >> > >> > >> @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1): > >> irq-status-read-quirk; > >> en2-rf-quirk; > >> t5t-rmb-extra-byte-quirk; > >> + vdd_io_1v8; > >> crystal_27mhz; > >> status = "okay"; > >> }; > > Rob - using the regulator binding is new to me, but I've given it a > shot and just sent you another set of patches for your inspection. > Please let me know if this is what you had in mind. This is my bad. Geoff followed my example and did something similar to 'vin-voltage-override' which shouldn't have been there in the first place. I have this fixed (I think) locally and will submit once it I'm back from my holiday travels. Mark --