Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755688AbcLUCWf (ORCPT ); Tue, 20 Dec 2016 21:22:35 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:60146 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbcLUCWd (ORCPT ); Tue, 20 Dec 2016 21:22:33 -0500 Date: Tue, 20 Dec 2016 19:22:29 -0700 From: Jens Axboe To: Paolo Valente CC: , , Subject: Re: [PATCH 6/8] blk-mq-sched: add framework for MQ capable IO schedulers Message-ID: <20161221022229.GA21762@kernel.dk> References: <1481933536-12844-1-git-send-email-axboe@fb.com> <1481933536-12844-7-git-send-email-axboe@fb.com> <4A1753A0-121C-4A01-8821-6CDD99C98896@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4A1753A0-121C-4A01-8821-6CDD99C98896@linaro.org> X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-20_19:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 507 Lines: 18 On Tue, Dec 20 2016, Paolo Valente wrote: > > + else > > + rq = __blk_mq_alloc_request(data, op); > > + > > + if (rq) { > > + rq->elv.icq = NULL; > > + if (e && e->type->icq_cache) > > + blk_mq_sched_assign_ioc(q, rq, bio); > > bfq needs rq->elv.icq to be consistent in bfq_get_request, but the > needed initialization seems to occur only after mq.get_request is > invoked. Can you do it from get/put_rq_priv? The icq is assigned there. If not, we can redo this part, not a big deal. -- Jens Axboe