Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958AbcLUDl4 (ORCPT ); Tue, 20 Dec 2016 22:41:56 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33078 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494AbcLUDly (ORCPT ); Tue, 20 Dec 2016 22:41:54 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] indention and space fixes to align with linux style From: Scott Matheina X-Mailer: iPhone Mail (14C92) In-Reply-To: <1482290625.1984.33.camel@perches.com> Date: Tue, 20 Dec 2016 21:41:52 -0600 Cc: gregkh@linuxfoundation.org, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-Id: <6BFFEC3B-AFD4-4391-8C42-AD4864012F03@matheina.com> References: <1482289187-7276-1-git-send-email-scott@matheina.com> <1482290625.1984.33.camel@perches.com> To: Joe Perches Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBL3fxGm003364 Content-Length: 2009 Lines: 66 > On Dec 20, 2016, at 9:23 PM, Joe Perches wrote: > >> On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote: >> Fixed indention and space issues to align the code with the linux style guide. > [] >> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > [] >> @@ -176,16 +176,16 @@ >> */ >> >> struct adt7316_chip_info { >> - struct adt7316_bus bus; >> - u16 ldac_pin; >> - u16 int_mask; /* 0x2f */ >> - u8 config1; >> - u8 config2; >> - u8 config3; >> - u8 dac_config; /* DAC config */ >> - u8 ldac_config; /* LDAC config */ >> - u8 dac_bits; /* 8, 10, 12 */ >> - u8 id; /* chip id */ >> + struct adt7316_bus bus; >> + u16 ldac_pin; >> + u16 int_mask; /* 0x2f */ >> + u8 config1; >> + u8 config2; >> + u8 config3; >> + u8 dac_config; /* DAC config */ >> + u8 ldac_config; /* LDAC config */ >> + u8 dac_bits; /* 8, 10, 12 */ >> + u8 id; /* chip id */ >> }; > > Hello Scott. > > I believe you're relatively new at this > patch submission stuff. > > The style above is fine and doesn't need > to be changed. It is not in CodingStyle > as preferred one way or the other. I would say very very new just a couple submissions so any advice would be great, drivers/staging is, so I'm told a good place to make mistakes >> /* >> @@ -212,13 +212,12 @@ struct adt7316_chip_info { >> */ >> >> struct adt7316_limit_regs { >> - u16 data_high; >> - u16 data_low; >> + u16 data_high; >> + u16 data_low; >> }; >> >> static ssize_t adt7316_show_enabled(struct device *dev, >> - struct device_attribute *attr, >> - char *buf) >> + struct device_attribute *attr, char *buf) > > This one isn't either but it is a very common > style in net/, drivers/net, and drivers/staging > though. >