Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758941AbcLUJau (ORCPT ); Wed, 21 Dec 2016 04:30:50 -0500 Received: from host.prodys.net ([89.248.106.65]:46520 "EHLO host.prodys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755585AbcLUJar (ORCPT ); Wed, 21 Dec 2016 04:30:47 -0500 Subject: Re: [PATCH v4 1/2] power: supply: add sbs-charger driver To: Manish Badarkhe References: <1482247874-28713-1-git-send-email-nicolas.saenz@prodys.net> <1482247874-28713-2-git-send-email-nicolas.saenz@prodys.net> Cc: sre@kernel.org, robh+dt@kernel.org, Mark Rutland , linux-pm@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Nicolas Saenz Julienne Message-ID: <72292f5b-3f81-f097-a87e-56b58098ff2b@prodys.net> Date: Wed, 21 Dec 2016 10:30:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 Dec 2016 09:30:25.0966 (UTC) FILETIME=[DC6974E0:01D25B6C] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 37 Hi Manish, thanks for the interest. On 20/12/16 17:54, Manish Badarkhe wrote: > Hi Nicola > [...] > > Just some general comment, Can you add some more properties here to > know voltage and current? I assume you are mentioning reading current and voltage values. These properties are not supported by the sbs-charger standard. All you can do is set (write only) the charging current and charging voltage values. Yet in all the boards I've worked with it's the sbs-battery compliant chip that takes care of it. > Also, can you add other properties present in charging status register > like POWER_FAIL, VOLTAGE_OR, > CURRENT_OR etc. CURRENT_OR and VOLTAGE_OR relate to wrong values in the charging voltage/current registers. Since the sbs-battery chip takes care of it I don't see any use for it. POWER_FAIL marks there is not enough voltage to charge the battery. I don't need that information so I did nothing to integrate it. Having a quick look at the power supply defines I don't see were it could easily fit. > Don't know weather it is feasible to add or not and Also, let me know, > if it is already been covered in > some part of the code. > > Thanks > Manish Badarkhe > Regards, Nicolas