Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762464AbcLUKJ5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Dec 2016 05:09:57 -0500
Received: from mail-qt0-f181.google.com ([209.85.216.181]:35719 "EHLO
        mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752006AbcLUKJr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Dec 2016 05:09:47 -0500
MIME-Version: 1.0
In-Reply-To: <72292f5b-3f81-f097-a87e-56b58098ff2b@prodys.net>
References: <1482247874-28713-1-git-send-email-nicolas.saenz@prodys.net>
 <1482247874-28713-2-git-send-email-nicolas.saenz@prodys.net>
 <CAKDJKT7WWFd2FSAZ6erXF=t1aaCyR0F5px54TiHw7C4PrnKXSQ@mail.gmail.com> <72292f5b-3f81-f097-a87e-56b58098ff2b@prodys.net>
From: Manish Badarkhe <badarkhe.manish@gmail.com>
Date: Wed, 21 Dec 2016 15:39:46 +0530
Message-ID: <CAKDJKT4zFB-Q6x5davDYpzgGfkRfoFqTOaL24MQjm_=b2B-Z5Q@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] power: supply: add sbs-charger driver
To: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
Cc: sre@kernel.org, robh+dt@kernel.org,
        Mark Rutland <mark.rutland@arm.com>, linux-pm@vger.kernel.org,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1238
Lines: 38

Hi Nicolas

On Wed, Dec 21, 2016 at 3:00 PM, Nicolas Saenz Julienne
<nicolas.saenz@prodys.net> wrote:
> Hi Manish, thanks for the interest.
>
> On 20/12/16 17:54, Manish Badarkhe wrote:
>> Hi Nicola
>>
> [...]
>>
>> Just some general comment, Can you add some more properties here to
>> know voltage and current?
>
> I assume you are mentioning reading current and voltage values. These
> properties are not supported by the sbs-charger standard. All you can do
> is set (write only) the charging current and charging voltage values.
> Yet in all the boards I've worked with it's the sbs-battery compliant
> chip that takes care of it.

thanks for clarifying me.


>> Also, can you add other properties present in charging status register
>> like POWER_FAIL, VOLTAGE_OR,
>> CURRENT_OR etc.
>
> CURRENT_OR and VOLTAGE_OR relate to wrong values in the charging
> voltage/current registers. Since the sbs-battery chip takes care of it I
> don't see any use for it.
> POWER_FAIL marks there is not enough voltage to charge the battery. I
> don't need that information so I did nothing to integrate it. Having a
> quick look at the power supply defines I don't see were it could easily fit.

thanks for clarifying me.

Regards
Manish Badarkhe