Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757253AbcLUKTH (ORCPT ); Wed, 21 Dec 2016 05:19:07 -0500 Received: from mailout2.hostsharing.net ([83.223.90.233]:38943 "EHLO mailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcLUKTE (ORCPT ); Wed, 21 Dec 2016 05:19:04 -0500 Date: Wed, 21 Dec 2016 11:19:15 +0100 From: Lukas Wunner To: John Crispin Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos Subject: Re: [PATCH] pci: add kernel config option for disabling common PCI quirks Message-ID: <20161221101915.GC14781@wunner.de> References: <1482306784-29224-1-git-send-email-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482306784-29224-1-git-send-email-john@phrozen.org> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 17 On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote: > From: Gabor Juhos > > These quirks do not effect small small plastic routers. These routers tend > to have very little flash space. This patch adds a new option that allows > us to build a kernel without including the common quirks, thus saving us > valuable flash space. > > When building an image for a MIPS/Ralink router with this option enabled > it will reduce the size of an uncompressed uImage by 12KB. There's already a PCI_QUIRKS config option defined in init/Kconfig, why isn't this sufficient? Do you want *some* quirks but not others? Thanks, Lukas