Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935050AbcLUMbJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Dec 2016 07:31:09 -0500
Received: from mail-lf0-f49.google.com ([209.85.215.49]:33392 "EHLO
        mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752933AbcLUMbG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Dec 2016 07:31:06 -0500
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: linux-wpan@vger.kernel.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
        Alexander Aring <aar@pengutronix.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chris Healy <cphealy@gmail.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Subject: Re: at86rf230: Allow slow GPIO pins for "rstn"
Date: Wed, 21 Dec 2016 15:30:52 +0300
Message-Id: <1482323452-10642-1-git-send-email-nikita.yoush@cogentembedded.com>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <1482103533-13187-1-git-send-email-andrew.smirnov@gmail.com>
References: <1482103533-13187-1-git-send-email-andrew.smirnov@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 565
Lines: 13

> Driver code never touches "rstn" signal in atomic context, so there's
> no need to implicitly put such restriction on it by using gpio_set_value
> to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to
> fix that.
> 
> As a an example of where such restriction might be inconvenient,
> consider a hardware design where "rstn" is connected to a pin of I2C/SPI
> GPIO expander chip.
> 
> Cc: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Reviewed-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>