Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758120AbcLUNQ3 (ORCPT ); Wed, 21 Dec 2016 08:16:29 -0500 Received: from nbd.name ([46.4.11.11]:41259 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754208AbcLUNQ1 (ORCPT ); Wed, 21 Dec 2016 08:16:27 -0500 Subject: Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f To: Cyrille Pitchen , Marek Vasut References: <1482304990-23942-1-git-send-email-john@phrozen.org> <1482304990-23942-3-git-send-email-john@phrozen.org> <91bb0b9c-93c0-755c-047b-2e86f099af02@atmel.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Andr=c3=a9_Valentin?= From: John Crispin Message-ID: Date: Wed, 21 Dec 2016 14:16:24 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <91bb0b9c-93c0-755c-047b-2e86f099af02@atmel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1746 Lines: 54 On 21/12/2016 11:27, Cyrille Pitchen wrote: > Hi all, > > Le 21/12/2016 à 08:23, John Crispin a écrit : >> From: André Valentin >> >> This patch adds support for a new macronix spi flash chip. We have had this >> patch inside our tree for a while and people are actively using routers >> with this chip. >> >> Signed-off-by: John Crispin >> Signed-off-by: André Valentin >> --- >> Changes in V2 >> * add description >> * add SECT_4K >> * fix indenting >> >> drivers/mtd/spi-nor/spi-nor.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index 171adb3..bfff159 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len) >> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) }, >> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) }, >> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) }, >> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) }, > > According to its datasheet, the Macronix MX25U3235F also supports Fast Read > 1-1-2 (3Bh) and Fast Read 1-1-4 (EBh) hence the SPI_NOR_DUAL_READ > and SPI_NOR_QUAD_READ flags should be set as well. > > Best regards, > > Cyrille Hi Cyrille, thanks for the help, I'll update the patches and get the original submitters to test them before resending the series John > >> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) }, >> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) }, >> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) }, >> >