Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759683AbcLUOXR (ORCPT ); Wed, 21 Dec 2016 09:23:17 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44969 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759599AbcLUOXP (ORCPT ); Wed, 21 Dec 2016 09:23:15 -0500 Subject: Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler To: Bart Van Assche , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "axboe@kernel.dk" References: <1481933536-12844-1-git-send-email-axboe@fb.com> <1481933536-12844-8-git-send-email-axboe@fb.com> <1482321550.2644.10.camel@sandisk.com> CC: "osandov@fb.com" , "paolo.valente@linaro.org" From: Jens Axboe Message-ID: <705f3ab2-5829-1d30-20ea-dc167cca6582@fb.com> Date: Wed, 21 Dec 2016 07:22:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482321550.2644.10.camel@sandisk.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BY1PR19CA0038.namprd19.prod.outlook.com (10.162.139.176) To MWHPR15MB1199.namprd15.prod.outlook.com (10.175.2.141) X-MS-Office365-Filtering-Correlation-Id: b6446e28-a5a7-45d1-65f2-08d429ace1f5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1199; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;3:ar0yBhILUT71B2WevLXBk2Gpxx+rUw/7OzX+y6T45kRAqEsgTjdmMRnhOPGiE7tvVB89c+4EtZPLQK+5vhjTLvAJGcXVTduM1PnBi9v2odAvqXYlHI+Fdeyn2I/UCbKvU47dob5e+aQxy7dHzARDY0Isa0sgXQ6ydIiXGZKzcHtFX605rEAqljWo6nHFK04UQx7uSfG8vQ2QLtwviE0q4+CQICAog4sJLhB2ggztNs0hy+aOTnFdRSQSWcdvQbgWeQfUaxHIZXvdDUPjuKfpCg==;25:jJJkIOxg4tB+xgBWG3pTl75R8Mg70BI7vf2tEMnn/vMFZ4gT78ikvbKGXOdDmoQO3GPdJ41x/loqsay88gkgGV5Zerth15eIh9Vm6feAWqmoAxHsCy/fDPDVqIWl4tkZyxhFvl5NgXfMbriQhnYQeFVfmzKyr6FJVyFi0Embf/682Mr1IWcFUNmLmo6VIgp9pvnZPsG+i2h0Ep+XoMO1BO9v0nJMc9cJlgcmkKBmaSjhWXOyNgFwomNawDLc6wp4/dPf33Yx0oGHq6y5oPfb5vUFTZYD1Fo251NZzIKeekbxl/pGQyYW0TvuqAexa5W4Y7I+406HtBzlB1kNxaUAUFTabx2mL95sj0AnvyO7pMjm7R3iL0XQQmaX1RsvHmtwLvlpm4JXFGki4w0GoStoIeQWyOdKAqzxoBtWnMTSff9++S5c8jTFCOHhx//brMZN5zO4DMaFRPsiDu5GJHTsDA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;31:c1v/pbkoUnricGFR8BN8MMmmiZLFIwIGnx5J/Ehirlh1qz4JFTW53c6R4lINKaXUbGzLmYJFk2LUeVWFf6tGbz6x7sNDNRG7UYlZdY5TS4NcbQk6oLt5lDyW/awlYdMqqa/Wc2G52DGKvnptct8SaIm/s/jkoU97L/ba2bxEboplRPMr6gN6cxjksaDbh2yEtu9ouEExZeOhtNL2EaREorHnfPTLazIRfChAmpHmY0udP1yYu3gXhdeC6lk16nrS;20:m9JGzYbuFCtjfSuEfBQX2kZofjvoqfYd7UXNc1eSOh+e3J0CP2Zx0XL20q5XvKu4/TnvnZSNJPKA2+XN6siSSnW+2ST7jiDn+7iFsNfAyptOt47KCdywMO2qoKvBU/rW4gM7hAw18nyWW4oWqYX4TjcjX9dVEXUtk8/hFUFrdrBOXIddaQir3AofCkJivrnHxMvtRrzjRcSB4yw13mfkWDB+hOvo4BzCuCQEgp4gRH1ibUuIXBsuCz+NiJe362dArkg/vg7FhakfJqai5ymPkrE92mya/GYbwBXhwymlxPEiit5OKHGLh/korrntrpd+So91Bv94du9AfxPUZIemfM8Wp4SXGzeqlhwKWgdpf0wbl9xucwTqSSif0W/Cl1PtpSSHbZGRWK+ArcGc6jKUqjleGBMbSoS4+VNd8FhfJN/6oTAtqF+Zs4ByVCPjN2dzioAqcqWsa57ZxSvj5nHfv+hoTQCOtGbd4s7jD0XWqgqKl62HOnPtUdO3Wq3yxYIs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:MWHPR15MB1199;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1199; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;4:6StK8PqFM4sD148ZwGmCbkQqmu/fuLd/+BnaaGTlFZFaox5ufwMSVc3F136wbH6BITsi2FsY1Gagk7SjQnXp6nvgQozppUt0DKIx3ngKd+mp1dCb4ZH1e3TOnochhpE+614Uf7ioOPccU5rVs+QZH+yR93Kytqc1iILBzRZNX+98qyKBYJuwaG+7kDtv8zo/YabVGv6LAM3QKURvgIMafNv2j9mB6T8WA+wkSK7Zp3crmfJT8wgVftELNKsoTr/4Ai2SfwobO5piVmunfak7JCOHrhJHaXErTAY6977sB6CrlzZIX/bW1QvM86J58hlXUxP1SxZgO9VKDctrNwoxjfc0p0JCPFyH/COYOIDszZCzjGXzgXCqW3lQ4twxVbEvsi7fc4N5hAB+GeWuZ4Wr0TtgK4evVZ+SwFOX9X0mo6JO0jcfU8MYHcqQdR26WqHNIly/7t9Nr2m22jUmY9Wresb5dajHigR/7UpFWISMhSBLNPeOPh4PdAcMfCWNYgaj85sqJ83Ai/oEg+COUM9uX4oySzvJW4IBQ/Gp/t1ViICV4CWJP/UpluIY9y5s1CyjUUgFi2P8uV1yaZK1aXArRQ== X-Forefront-PRVS: 01630974C0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39830400002)(39450400003)(189002)(377454003)(199003)(24454002)(65806001)(81156014)(189998001)(6116002)(6666003)(305945005)(65826007)(68736007)(66066001)(76176999)(86362001)(92566002)(77096006)(90366009)(117156001)(31696002)(2201001)(81166006)(101416001)(50986999)(6486002)(38730400001)(2906002)(54356999)(2950100002)(4326007)(33646002)(47776003)(230700001)(65956001)(36756003)(97736004)(229853002)(106356001)(5660300001)(25786008)(83506001)(5001770100001)(23676002)(42186005)(1691005)(31686004)(7736002)(50466002)(8676002)(105586002)(2501003)(64126003)(4001350100001)(8666006)(3846002)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1199;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjE1TUIxMTk5OzIzOmRMTmR1TGhQUXgxMnVZVGkzL2plQU9Cb2Jq?= =?utf-8?B?VE1ZQm1jTUk0OCt3YWQ0MDJIdnk4RVVMMmZEaHFSYkNIMjM0a0Mza3pjZVdL?= =?utf-8?B?cHlmVDZGSUs2YTJjTXU4NlQ2VmhjSzZpb2VKVUhudHdiaExqd2g3MUw5NE5O?= =?utf-8?B?WlUwU3k1RzlVSEZjQzhNYkIxV3pvUVRBYjZOeFlZUnZ0MXBEM0RlK2w2RGUz?= =?utf-8?B?cG51STJidk5oeEhhY3RJbWpaT0lVbHgyck0rdHFwYzBvSUMybkxrVmYzem1n?= =?utf-8?B?OFpKRUxuNXJxYWo3OFlGVlQvd1BJY3VLSE02Tnh6N0xONEJZM2FTV0d4ZVJ6?= =?utf-8?B?VFlaN3RZdmQ4TlF2ZWZyRllHUGY0bFVLeURkbmhDRERDWWtnV2NjQ1UxRDFk?= =?utf-8?B?bWhvYVNIOWJJOEhVcDZ0Qk1oVHptbXJzVzF2Mms1Vm9xWTZrdXYxMGZGQWhE?= =?utf-8?B?Z0dOQjAvOGFtNTBuTGZlZld5bEVIRUI4dThFV29lY1FvVVYza3o1WldOSWxK?= =?utf-8?B?MUxWSSthdXVxVVFpVzd1c3lpbGFVZTRPbU9DZzVONzdWcEJwRytYaVMveHdw?= =?utf-8?B?eUxtcTgwbDVudGxUYW9HN25nU3JOWU5qbUZvdzJadTFsbi8yWEE2ek96Q21X?= =?utf-8?B?RWtDZXBsOU1OSmpJZ1VQazFxR2hPaDlQOVRRS1pib3FEQ3JGZStEK2ZTbFVx?= =?utf-8?B?cmNQTWlrSlRyOUJhWkFZTHhOQlhwdGpUbHJ3TzJOOVlRcTBPU3lkdWljNU1q?= =?utf-8?B?TEoyakxmVjkvMnUwcWpaRU4wTE1mTXByS1ZlWEVlUDVoZm1uaXl1SDMyNEZX?= =?utf-8?B?d205bElIcTNkaEJObVZnOHN2WDlsT2xyRVA4cVI1L01rZXQzb1RDVkVSWWNY?= =?utf-8?B?N2pRcUlKaDZUajc3MWpzM05zLzByRVg5NkpjKzBscUVTNXJNNlJjTlVVdDFy?= =?utf-8?B?cUZhZ3VrL0ZNajBmb2lsUnlsTW11d244UldaTnovYVFFVG5wc2htYkNLQ3BC?= =?utf-8?B?SXU0cENsTGZNM25zZTlUZ2VIWEZzeDA5RndleVFiNktwSXc2Q2FaT014M0pt?= =?utf-8?B?djRDQXoyUitFb0UzV2VIWXlLYnorb3RlakRvWmNlbVZJKy9HaW9FdE95b0Uv?= =?utf-8?B?UGd2aVZlTEp1UlhyOUlVZFBzS3N0aVlmTnFZRkhPUjBNRTAwdXNaT3QrM3Fp?= =?utf-8?B?KzRzc0w3U1pwV1l2aDhxVXkzUFNvbWxrbjU5OEZwSXp6cmlyRFg4OUNORUlJ?= =?utf-8?B?cmJCdzRnQkhUMFJ4Y05LRXVuS3dUa2grazBwTDcxUS9rQWp4a1lHWmE2cTFE?= =?utf-8?B?WWo0U0xjWEQzYW9hY3V5RU5IRzhyTFdEQnhxRXZtQ2JBdjhCMUhPK1AwQlVl?= =?utf-8?B?d1VIalVIdjhHcG1SQVVCQU5wOUV0U09Ea3RaaHkyL3d2dWt1WTdkVmNodDJ3?= =?utf-8?B?VHpkYUlCWkpSOWczTHh3UHdBOXpYRzJxN1lCSE1zb2xxZlNKQ3ZHbVR1SU1x?= =?utf-8?B?aGQzVUZzRmpnL29GNjBWbDZOWlpZdWpMcmxtVGplQjJ1RGl3bTllZW9jQWJi?= =?utf-8?B?UXdIc1pLRytaQmFpNllrUjJ2UzZxbTZXS1J6dkNyWXBuNmlzU25lNkwzTnhS?= =?utf-8?B?WWNCZS85WjNCc29BanU1S2hGdzN0SU1ORUhHTXhDOEFGeGVQMFRkTlgxcCt4?= =?utf-8?B?RUQ4ZG5sMGJTSVNhb2lld2hXendxRWE0UnRBRWNoR2VoM25jRDN4bE0ybEtU?= =?utf-8?B?UDFLUGZZZmNEK250ZTlTcjU3NDFESHdUbktlT2JKWFUyL3YwZUJtdHBKdUVL?= =?utf-8?B?cHUyWFNFd25ZelBVQmxhV3EwR3dMeDRlWFZQdUhqZGliRGtvTHR6UnQxajdK?= =?utf-8?B?ai95c045ZW5heTEwWk04ZGJ0Q2JLR1dMZUZGZzFBYTdDMjlvTW8xT0c2Ukl3?= =?utf-8?B?L3JBdC8yS3lyN3dIZE5rY284VVBiWlRHSnJJR2gzaVRvc0dxQ0lwUzd5U3A5?= =?utf-8?B?Wk9HSU56My96NmJBaDRFYlBCRXpwN2RGQnlyVEI4Z21pRll6WWFKTE1kVGlt?= =?utf-8?Q?PLIc=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;6:YUU75oEjfObBYWrAfINiwCYkNkAEXHKDNnxn5vJqG+h3BvXlAAE0BJN125BGAElldBk+1Q0Xzc0Je2jG1+xAkxN21bDIx3D7IGSGxkFWgHnulc52do6EqApsy/mMSzqv7cKMS66bOVUVwVi9rsHMvXi488QA9R6py1ytbXy07DiPuFOX0J/b4RXN7luKTE5nN4PPSBlAE1ed+6r4ANJWSaCvfJC/XnCcmxDNBO3IRQSdxl1BjqSUccaOIhsTKuhF6+MTcxydxhV7exIs457fr48oG//tOg469evM7f71q7MXPfcDbprrVzAzXUBwK6wlTTFxzZZFY3My1MQQD8zuj9oumNfewVrWww0idnbdhyjO+KscBGVXQEGQxMMjT+TeJAl+cAiXAe03LRpAaAClX6R4HG0Cu1ZkesQPEpPrEAk=;5:FMjmYpj4T4nHkagebd/ax/dvRNJez9kBA5AJ43WYYTjIWgfc6qhK3Bhi8ebBa85e6vwvyqZwMOmVWMj3eCQl60xARIEMURS4SaSbkveOaDVlrMJqMydrqQNsEq99IJGHRX6Be8CMiQXkvTLYgW35CZuZRlqbC4EBiSsDLlGPqi4=;24:7yyy0eywUlnBR670h93tIZDYe6oTut+Y2p1m0YnJG45M9s4wS4WnRszAnfMJsE5KdIuYWLZW9FXgJKcXl6Vfx4q7S6BzslRWCeFclztYkPE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;7:IK729wkupBs+RspUxnEc4ESbfqWC7L4pHFsacKdybF72C1TYhlq6cQtujQekjEFzFm/zTdbzzlnJ9M43aIpG0eLNkibrusVeIMt8P8IIgqmgsBWig1gRV2AaDcAss/sTaIz/qR4gvfn+CaK+yoRgXDtFBwAFfG6SMvvC61grr2TaNk54qYPt/KwhkAMxsyz86NPObP1k9TVy+T84Gdbxd56fVzxQaGZXKos3k8W0CbeR21ia66CodGGwwT9HWdWHmCBft1cQLxpQYwmr0rUma8ycMsWriwR4NSOfdGnPQP/aBUxADuTFrSIL72/L093ThDj0De1mKy9XR9LB0ckHPJJbsXqj5007Dvrl1T6gJsSBOEkFzoSGYPVLI8KW3ACVX4bb27BrZh5ruBOUiYzbHBHj1ODwnFbkACS08upRw8w9aQAqCNAhBuTO4zSCD2mlmIgLJwPT+XcqFTiIDzKGKg==;20:RoQ1XurF2F4pl7pO91M2pVNDngOyaysqCUDpW+aRviiBHssosZoi5ETYlsdYlzRDc2b2JktEpdOwmjFmw6hxYB6gT20CJ41uIEGzfmO47VjSgWIBTTrdwQuO8ZweLRaubPird+eOcqGkOVCOYzv63OhiTUttLrbBRWsYWq5hIsU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 14:23:06.3518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1199 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-21_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 17 On 12/21/2016 04:59 AM, Bart Van Assche wrote: > Since this patch is the first patch that introduces a call to > blk_queue_exit() from a module other than the block layer core, > shouldn't this patch export the blk_queue_exit() function? An attempt > to build mq-deadline as a module resulted in the following: > > ERROR: "blk_queue_exit" [block/mq-deadline.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 > make: *** [Makefile:1198: modules] Error 2 > Execution failed: make all Yes, it should. I'll make the export for now, I want to move that check and free/drop into the generic code so that the schedulers don't have to worry about it. -- Jens Axboe