Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936172AbcLUPj6 (ORCPT ); Wed, 21 Dec 2016 10:39:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935955AbcLUPjv (ORCPT ); Wed, 21 Dec 2016 10:39:51 -0500 Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi To: Christoph Hellwig , Roman Kagan , Stephen Hemminger , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "K. Y. Srinivasan" , Vitaly Kuznetsov , kvm@vger.kernel.org, "Denis V . Lunev" , Haiyang Zhang , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , devel@linuxdriverproject.org, Thomas Gleixner References: <20161220155602.6298-1-rkagan@virtuozzo.com> <20161220155602.6298-13-rkagan@virtuozzo.com> <20161220092543.6183bffd@xeon-e3> <20161221062939.GB15917@rkaganb.sw.ru> <20161221121858.GA17429@infradead.org> <20161221125920.GG15917@rkaganb.sw.ru> <20161221142654.GB8594@infradead.org> From: Paolo Bonzini Message-ID: Date: Wed, 21 Dec 2016 16:39:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161221142654.GB8594@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 21 Dec 2016 15:39:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 25 On 21/12/2016 15:26, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: >> That's fine by me. >> >> I guess the series should then start with a complete move >> arch/x86/include/uapi/asm/hyperv.h -> >> arch/x86/include/asm/hyperv_proto.h, and the remaining patches have to >> change the latter instead of the former? > > That would be my preference, but we'll need to figure out why > hyperv has ever been a UABI header, and if anyone is using it. QEMU uses it, but we already bundle the header files and update them periodically from the files that Linux installs. So any change in Linux would not break the QEMU build; having the header in UAPI is convenient but I guess our update scripts could do whatever Linux's scripts/headers_install.sh does. That said, there are precedents in using UAPI this way for PV interfaces. See for example include/uapi/linux/virtio*.h and arch/x86/include/uapi/asm/kvm_para.h. Paolo