From: Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
To: joe@perches.com
Cc: akpm@linux-foundation.org, bongkyu.kim@lge.com,
        sergey.senozhatsky@gmail.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org,
        Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
Subject: Re: [PATCH 3/3] lib: Update LZ4 compressor module based on LZ4 v1.7.2.
Date: Wed, 21 Dec 2016 21:04:02 +0100
Message-Id: <1482350642-13119-1-git-send-email-4sschmid@informatik.uni-hamburg.de>
In-Reply-To: <1482263555.1984.28.camel@perches.com>
References: <1482263555.1984.28.camel@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1213
Lines: 35

On 12/20/2016 08:52 PM, Joe Perches wrote:
> On Tue, 2016-12-20 at 19:53 +0100, Sven Schmidt wrote:
>> This patch updates LZ4 kernel module to LZ4 v1.7.2 by Yann Collet.
>> The kernel module is inspired by the previous work by Chanho Min.
>> The updated LZ4 module will not break existing code since there were alias
>> methods added to ensure backwards compatibility.
>
>[]
>
>> diff --git a/include/linux/lz4.h b/include/linux/lz4.h
> []
>> @@ -1,87 +1,218 @@
>>  #ifndef __LZ4_H__
>>  #define __LZ4_H__
>> +
>>  /*
>>   * LZ4 Kernel Interface
>>   *
>> - * Copyright (C) 2013, LG Electronics, Kyungsik Lee <kyungsik.lee@lge.com>
>> + * Copyright (C) 2016, Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
>
> Deleting copyright notices is poor form and shouldn't be done.
>
> I didn't look at the rest
>

Thanks Joe for your time. If you would take a look at the rest, you may notice
that I changed almost the whole file. That's why I also changed the copyright note.
If you think I should keep the original note, I will do that.

What I did change:
- I included additional information stating that the file is based on Yann Collets
original header file (especially in matters of the function comments)

Sven