Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754338AbcLUUmt (ORCPT ); Wed, 21 Dec 2016 15:42:49 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:48582 "EHLO omr1.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751316AbcLUUmr (ORCPT ); Wed, 21 Dec 2016 15:42:47 -0500 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: Petr Mladek , Jessica Yu Cc: linux-kernel@vger.kernel.org Subject: Patch to include/linux/kernel.h breaks 3rd party modules. From: Valdis Kletnieks Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1482352925_2781P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Wed, 21 Dec 2016 15:42:05 -0500 Message-ID: <30992.1482352925@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 62 --==_Exmh_1482352925_2781P Content-Type: text/plain; charset="us-ascii" Content-Id: <30968.1482352904.1@turing-police.cc.vt.edu> Yes, I know that usually out-of-tree modules are on their own. However, this one may require a rethink.. (Sorry for not catching this sooner, I hadn't tried to deal with the affected module since this patch hit linux-next in next-20161128) commit 7fd8329ba502ef76dd91db561c7aed696b2c7720 Author: Petr Mladek Date: Wed Sep 21 13:47:22 2016 +0200 taint/module: Clean up global and module taint flags handling Contains this chunk: --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -506,6 +506,15 @@ extern enum system_states { #define TAINT_UNSIGNED_MODULE 13 #define TAINT_SOFTLOCKUP 14 #define TAINT_LIVEPATCH 15 +#define TAINT_FLAGS_COUNT 16 + +struct taint_flag { + char true; /* character printed when tainted */ + char false; /* character printed when not tainted */ + bool module; /* also show as a per-module taint flag */ +}; and hilarity ensues when an out-of-tree module has this: # ifndef true # define true (1) # endif # ifndef false # define false (0) # endif My proposed fix: change true/false to tainted/untainted. If this is agreeable, I'll code and submit the fix. --==_Exmh_1482352925_2781P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.5 07/13/2001 iQEVAwUBWFrpHY0DS38y7CIcAQIeFwf/VjbfkeH+apzUpKbc5eCBlJHznmvLgTyk cvxDt58SMivwFCNLrHKlVmVlrXMkRCpV7SfptfVoBc4MWfiOIskQheUnAX/y1nGL 2vTsZFW2JHACeWwF1BbFDEbT2qbRRbVryVPm9q4s7vS+7Mt99FDcCbHeykFZSwhE CkYsR8qUvuX+k48o1YoOuNASF1MpbtmA8DJzouiq3XAOalCPHduuTZ7gAubHEI5z kbL5ZEe2WRpHVRQfMUQ4JpajDXvscZpbMAN5X9fPHlYApGSV/VB5lUYvxDv73b6i h36ZHshjnPznTSgv8Yswr/XLu70ik3ie5O5cgmqk5hYR70XMSH9jHQ== =J891 -----END PGP SIGNATURE----- --==_Exmh_1482352925_2781P--