Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761639AbcLUWa7 (ORCPT ); Wed, 21 Dec 2016 17:30:59 -0500 Received: from mail-wj0-f180.google.com ([209.85.210.180]:34948 "EHLO mail-wj0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758195AbcLUWa5 (ORCPT ); Wed, 21 Dec 2016 17:30:57 -0500 Date: Wed, 21 Dec 2016 22:30:54 +0000 From: Matt Fleming To: Petr Oros Cc: ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/efi Fix regression in efi_arch_mem_reserve Message-ID: <20161221223054.GG2225@codeblueprint.co.uk> References: <20161221131138.10512-1-poros@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161221131138.10512-1-poros@redhat.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 23 On Wed, 21 Dec, at 02:11:38PM, Petr Oros wrote: > Booting on EFI with ESRT table has been stop since commit: > 8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() > > This is caused by this commit: > 816e761 efi: Allow drivers to reserve boot services forever > > Problem is, that efi_memmap_insert need memory aligned > on EFI_PAGE_SIZE. If memory not aligned, efi_memmap_insert > just return and let efi.memmap in inconsistent state. > This breaking boot. > > Tested in my machine, which stop booting > after upgrade to 4.9 > > Signed-off-by: Petr Oros > --- > arch/x86/platform/efi/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Could you provide some more information? Why does efi_memmap_insert() require this alignment? How does booting "break"? If you see an Oops, please post it here.