Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761747AbcLUXbF (ORCPT ); Wed, 21 Dec 2016 18:31:05 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34203 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757806AbcLUXbD (ORCPT ); Wed, 21 Dec 2016 18:31:03 -0500 From: Wei Yang To: trivial@kernel.org, akpm@linux-foundation.org, mhocko@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang Subject: [PATCH V3 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory() Date: Wed, 21 Dec 2016 23:30:32 +0000 Message-Id: <1482363033-24754-2-git-send-email-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1482363033-24754-1-git-send-email-richard.weiyang@gmail.com> References: <1482363033-24754-1-git-send-email-richard.weiyang@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 31 memblock_is_region_memory() invoke memblock_search() to see whether the base address is in the memory region. If it fails, idx would be -1. Then, it returns 0. If the memblock_search() returns a valid index, it means the base address is guaranteed to be in the range memblock.memory.regions[idx]. Because of this, it is not necessary to check the base again. This patch removes the check on "base". Signed-off-by: Wei Yang --- mm/memblock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 7608bc3..4929e06 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1615,8 +1615,7 @@ int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size if (idx == -1) return 0; - return memblock.memory.regions[idx].base <= base && - (memblock.memory.regions[idx].base + + return (memblock.memory.regions[idx].base + memblock.memory.regions[idx].size) >= end; } -- 2.5.0